Issue 14530043: Prepare env when running metadata plugins

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14530043: Prepare env when running metadata plugins (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by wallyworld

Modified:
10 years, 6 months ago

Reviewers:
mp+189784, fwereade

Visibility:
Public.

Description

Prepare env when running metadata plugins When initialising the env before running the metadata plugins, the NewFromName api was used. This has been changed to PrepareFromName to fit in with the new env logic. Tests have been added to ensure that the correct user error message is shown, and some test refactoring has been done to accommodate the new tests. https://code.launchpad.net/~wallyworld/juju-core/robust-metadata-plugins/+merge/189784 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -4 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/plugins/juju-metadata/validateimagemetadata.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	cmd/plugins/juju-metadata/validateimagemetadata_test.go	View	3 chunks	+23 lines, -2 lines	0 comments	Download
M	cmd/plugins/juju-metadata/validatetoolsmetadata.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	cmd/plugins/juju-metadata/validatetoolsmetadata_test.go	View	3 chunks	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM for trunk and 1.16

Expand All Messages | Collapse All Messages