Issue 14529050: rpc: new Request type

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14529050: rpc: new Request type

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by rog

Modified:
10 years, 6 months ago

Reviewers:
gz, mp+190369

Visibility:
Public.

Description

rpc: new Request type We'll use this to allow log messages to be filtered by request. There was an existing type "request" inside the rpc package which I've renamed to make the distinction more clear. https://code.launchpad.net/~rogpeppe/juju-core/446-rpc-request/+merge/190369 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : rpc: new Request type #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+102 lines, -75 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	rpc/client.go	View	5 chunks	+5 lines, -11 lines	0 comments	Download
M	rpc/jsoncodec/codec.go	View	2 chunks	+8 lines, -6 lines	0 comments	Download
M	rpc/jsoncodec/codec_test.go	View	4 chunks	+20 lines, -12 lines	0 comments	Download
M	rpc/rpc_test.go	View	16 chunks	+26 lines, -26 lines	0 comments	Download
M	rpc/server.go	View	5 chunks	+36 lines, -19 lines	0 comments	Download
M	state/api/apiclient.go	View	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM, eminently sane.

Expand All Messages | Collapse All Messages