Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9099)

Issue 14526043: Changed recommended charm indicator (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by huwshimi
Modified:
10 years, 6 months ago
Reviewers:
mp+189766, gary.poster
Visibility:
Public.

Description

Changed recommended charm indicator Added the new recommended charm indicator to the charm token and charm/bundle details. Moved the selected token line to the left as per new mockups. https://code.launchpad.net/~huwshimi/juju-gui/recommended-charms/+merge/189766 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Changed recommended charm indicator #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -169 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
D app/assets/images/approved_star.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D app/assets/images/non-sprites/badge-approved.svg View 1 chunk +0 lines, -144 lines 0 comments Download
A app/assets/images/recommended-triangle.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/assets/images/recommended-triangle-large.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M app/subapps/browser/templates/browser_charm.handlebars View 1 3 chunks +12 lines, -8 lines 1 comment Download
M app/templates/bundle-token.handlebars View 1 chunk +3 lines, -1 line 0 comments Download
M app/templates/charm-token.handlebars View 1 chunk +3 lines, -1 line 0 comments Download
M lib/views/browser/charm-full.less View 1 2 chunks +14 lines, -1 line 0 comments Download
M lib/views/browser/token.less View 1 3 chunks +8 lines, -17 lines 0 comments Download

Messages

Total messages: 5
huwshimi
Please take a look.
10 years, 6 months ago (2013-10-08 06:08:48 UTC) #1
rharding
The code looks ok, but the QA needs to be checked on. The way things ...
10 years, 6 months ago (2013-10-08 12:20:51 UTC) #2
huwshimi
Please take a look.
10 years, 6 months ago (2013-10-09 04:09:49 UTC) #3
gary.poster
LGTM and qa ok. Landing. Thank you! Gary https://codereview.appspot.com/14526043/diff/16001/app/subapps/browser/templates/browser_charm.handlebars File app/subapps/browser/templates/browser_charm.handlebars (right): https://codereview.appspot.com/14526043/diff/16001/app/subapps/browser/templates/browser_charm.handlebars#newcode24 app/subapps/browser/templates/browser_charm.handlebars:24: Deployed ...
10 years, 6 months ago (2013-10-09 12:59:46 UTC) #4
gary.poster
10 years, 6 months ago (2013-10-09 13:06:19 UTC) #5
*** Submitted:

Changed recommended charm indicator

Added the new recommended charm indicator to the charm token and charm/bundle
details.

Moved the selected token line to the left as per new mockups.

R=rharding, gary.poster
CC=
https://codereview.appspot.com/14526043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b