Issue 14523043: code review 14523043: misc/emacs: don't treat (foo)(bar) as a function call w...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14523043: code review 14523043: misc/emacs: don't treat (foo)(bar) as a function call w... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by Dominik Honnef

Modified:
11 years, 6 months ago

Reviewers:
adonovan

CC:
adonovan, golang-dev

Visibility:
Public.

Description

misc/emacs: don't treat (foo)(bar) as a function call when preceded by a word character. Fixes issue 6531.

Patch Set 1 #

Patch Set 2 : diff -r ad51691011d3 https://code.google.com/p/go #

Patch Set 3 : diff -r ad51691011d3 https://code.google.com/p/go #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	misc/emacs/go-mode.el	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Dominik Honnef

Hello adonovan@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 7 months ago (2013-10-08 03:21:27 UTC) #1

adonovan

On 2013/10/08 03:21:27, Dominik Honnef wrote: > Hello mailto:adonovan@google.com (cc: mailto:golang-dev@googlegroups.com), > > I'd like ...

11 years, 6 months ago (2013-10-10 20:28:11 UTC) #2

adonovan

11 years, 6 months ago (2013-10-10 20:30:25 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=fa3d26c6bb94 ***

misc/emacs: don't treat (foo)(bar) as a function call when preceded by a word
character.

Fixes issue 6531.

R=adonovan
CC=golang-dev
https://codereview.appspot.com/14523043

Committer: Alan Donovan <adonovan@google.com>

Expand All Messages | Collapse All Messages