code review 14515044: math: the trig functions work in radians; document that

math: the trig functions work in radians; document that
Fixes issue 6543
6543 is also a fine NGC object.

[r, 2013-10-07 22:24:48]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[dsymonds, 2013-10-07 22:47:36]

LGTM

Though I was taught in school that those functions always work in radians,
so it seems a bit redundant. Making it clear is probably worth that.

[kisielk, 2013-10-07 23:12:53]

LGTM

What's an NGC object?

[minux1, 2013-10-07 23:26:04]

On Oct 7, 2013 6:47 PM, "David Symonds" <dsymonds@golang.org> wrote:
> Though I was taught in school that those functions always work in
radians, so it seems a bit redundant. Making it clear is probably worth
that.
it seems education differs around the world, as i was first exposed to
trig. functions working on degrees (esp. sin/cos/tan) and then those on
radians.

anyway, this change LGTM.

[r, 2013-10-07 23:31:47]

I agree with David but there's no harm in being clear.

[r, 2013-10-07 23:32:44]

*** Submitted as https://code.google.com/p/go/source/detail?r=feda27244645 ***

math: the trig functions work in radians; document that
Fixes issue 6543
6543 is also a fine NGC object.

R=golang-dev, dsymonds, kamil.kisiel, minux.ma
CC=golang-dev
https://codereview.appspot.com/14515044

[iant, 2013-10-08 00:04:36]

On Mon, Oct 7, 2013 at 4:12 PM,  <kamil.kisiel@gmail.com> wrote:
>
> What's an NGC object?

http://messier.seds.org/xtra/ngc/n6543.html

Ian

[mtj1, 2013-10-08 14:26:29]

6543 is "51R" in base 36, and that's a runway at the Madisonville, Texas
airport.

Something to keep in mind for future checkin commentary if issue 6543 needs
a further edit.


On Mon, Oct 7, 2013 at 5:04 PM, Ian Lance Taylor <iant@golang.org> wrote:

> On Mon, Oct 7, 2013 at 4:12 PM,  <kamil.kisiel@gmail.com> wrote:
> >
> > What's an NGC object?
>
> http://messier.seds.org/xtra/ngc/n6543.html
>
> Ian
>
> --
>
> ---
> You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>



-- 
Michael T. Jones | Chief Technology Advocate  | mtj@google.com |  +1
650-335-5765