Issue 14511053: Add command to sign metadata

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14511053: Add command to sign metadata (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by wallyworld

Modified:
10 years, 6 months ago

Reviewers:
mp+190026, fwereade

Visibility:
Public.

Description

Add command to sign metadata A new metadata plugin is added which inline signs simplestreams metadata. https://code.launchpad.net/~wallyworld/juju-core/sign-metadata/+merge/190026 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+671 lines, -94 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/plugins/juju-metadata/metadata.go	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	cmd/plugins/juju-metadata/metadataplugin_test.go	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	cmd/plugins/juju-metadata/signmetadata.go	View	1 chunk	+109 lines, -0 lines	1 comment	Download
A	cmd/plugins/juju-metadata/signmetadata_test.go	View	1 chunk	+103 lines, -0 lines	0 comments	Download
A	environs/imagemetadata/export_test.go	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	environs/imagemetadata/simplestreams.go	View	2 chunks	+60 lines, -0 lines	0 comments	Download
M	environs/imagemetadata/simplestreams_test.go	View	3 chunks	+134 lines, -0 lines	0 comments	Download
M	environs/simplestreams/decode.go	View	2 chunks	+2 lines, -61 lines	0 comments	Download
A	environs/simplestreams/encode.go	View	1 chunk	+52 lines, -0 lines	0 comments	Download
M	environs/simplestreams/export_test.go	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	environs/simplestreams/simplestreams.go	View	9 chunks	+20 lines, -11 lines	0 comments	Download
M	environs/simplestreams/simplestreams_test.go	View	2 chunks	+4 lines, -14 lines	0 comments	Download
M	environs/simplestreams/testing/testing.go	View	1 chunk	+41 lines, -0 lines	0 comments	Download
M	environs/tools/export_test.go	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	environs/tools/simplestreams.go	View	2 chunks	+10 lines, -0 lines	0 comments	Download
M	environs/tools/simplestreams_test.go	View	3 chunks	+110 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fwereade

This looks like it's missing a prereq. Assuming the erroneously-included changes are the ones I ...

10 years, 7 months ago (2013-10-09 08:25:11 UTC) #2

wallyworld

10 years, 6 months ago (2013-10-09 10:57:34 UTC) #3

On 2013/10/09 08:25:11, fwereade wrote:
> This looks like it's missing a prereq. Assuming the erroneously-included
changes
> are the ones I just reviewed elsewhere, this also LGTM for trunk and 1.16
> 
>
https://codereview.appspot.com/14511053/diff/1/cmd/plugins/juju-metadata/sign...
> File cmd/plugins/juju-metadata/signmetadata.go (right):
> 
>
https://codereview.appspot.com/14511053/diff/1/cmd/plugins/juju-metadata/sign...
> cmd/plugins/juju-metadata/signmetadata.go:26: The specified keyring file is
> expected to contain an amored private key. If the key
> s/amored/armo[u]?red/
> 
> (did I hear someone say "we're a uk company, we use uk spelling" recently?)

I used the US spelling (to my disdain) to be consistent with the API spelling to
avoid confusion

Expand All Messages | Collapse All Messages