Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5853)

Issue 14503043: Make \tweak ... Grob equivalent to \override rather than \once \override (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by dak
Modified:
10 years, 2 months ago
Reviewers:
Keith, janek
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Make \tweak ... Grob equivalent to \override rather than \once \override This simplifies several uses of tweak for both tweak and override. When desired, one can use \once \tweak in order to get either tweak or override-once semantics: in the case of the tweak semantics, \once will just ignore the contained expression.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Shiver me timbers! Forgot the change itself. Thanks, Keith. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -19 lines) Patch
M ly/music-functions-init.ly View 1 6 chunks +28 lines, -19 lines 0 comments Download

Messages

Total messages: 5
Keith
I'm not sure what you are trying to do, but if you mean to make ...
10 years, 6 months ago (2013-10-13 03:27:16 UTC) #1
dak
Shiver me timbers! Forgot the change itself. Thanks, Keith.
10 years, 6 months ago (2013-10-13 05:42:18 UTC) #2
janek
Do i understand correctly that with this patch one can use \tweak to achieve everything ...
10 years, 6 months ago (2013-10-15 21:51:22 UTC) #3
dak
On 2013/10/15 21:51:22, janek wrote: > Do i understand correctly that with this patch one ...
10 years, 6 months ago (2013-10-15 22:07:34 UTC) #4
janek
10 years, 6 months ago (2013-10-15 22:15:36 UTC) #5
2013/10/16  <dak@gnu.org>:
> That's not really the main point.  It would have been simple previously
> to make \tweak be equivalent to \override rather than \once \override
> when used on symbol lists.
>
> \tweak syntax for overrides is not really pretty, but it makes it easy
> to implement mixed tweaks/overrides like \hide or \omit.  But there are
> some changes which only make sense as a \once\override or a \tweak (like
> footnotes), and now one can write \once\tweak without a problem, even
> when it turns out \tweak is being indeed used as a \tweak and not as an
> \override.
>
> It's not really an advertisable feature: it's just making several tools
> fit the same handle for convenience, but it's not like the resulting
> look is particularly elegant.


Indeed, it's not elegant.  But i hope that one day there will be an
elegant tool that could do everything; this patch is a move in that
direction so i support it despite it being not elegant.

best,
Janek
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b