Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2088)

Issue 14502061: Bundle topology rendering fails gracefully

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by jeff.pihach
Modified:
10 years, 6 months ago
Reviewers:
mp+190769, gary.poster
Visibility:
Public.

Description

Bundle topology rendering fails gracefully If the bundle does not provide proper xy position annotations on any of the services in its deployer file we do not render the bundle topology and instead remove the bundle topology tab, selecting the Charms tab to show the charms the bundle contains. Because we don't have any bundles with proper positions right now I added the flag `strictBundle` to enable this feature. https://code.launchpad.net/~hatch/juju-gui/bundle-fail-gracefully/+merge/190769 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Bundle topology rendering fails gracefully #

Patch Set 3 : Bundle topology rendering fails gracefully #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -23 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/subapps/browser/views/bundle.js View 1 1 chunk +48 lines, -8 lines 0 comments Download
M test/test_bundle_details_view.js View 1 7 chunks +77 lines, -15 lines 0 comments Download

Messages

Total messages: 4
jeff.pihach
Please take a look.
10 years, 6 months ago (2013-10-11 21:58:17 UTC) #1
gary.poster
Small test change requested, and otherwise code is LGTM. doing qa now. https://codereview.appspot.com/14502061/diff/1/test/test_bundle_details_view.js File test/test_bundle_details_view.js ...
10 years, 6 months ago (2013-10-11 22:03:48 UTC) #2
jeff.pihach
Please take a look.
10 years, 6 months ago (2013-10-11 22:52:21 UTC) #3
jeff.pihach
10 years, 6 months ago (2013-10-11 23:01:26 UTC) #4
*** Submitted:

Bundle topology rendering fails gracefully

If the bundle does not provide proper xy position annotations
on any of the services in its deployer file we do not render
the bundle topology and instead remove the bundle topology
tab, selecting the Charms tab to show the charms the 
bundle contains.

Because we don't have any bundles with proper positions right
now I added the flag `strictBundle` to enable this feature.

R=gary.poster
CC=
https://codereview.appspot.com/14502061
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b