Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2142)

Issue 14499043: Build new_services more carefully

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by matthew.scott
Modified:
10 years, 6 months ago
Reviewers:
gary.poster, mp+189665
Visibility:
Public.

Description

Build new_services more carefully Some services that were not actually new were being considered as such because their annotations hadn't been processed as attributes yet - this occurred specifically in drag-and-drop scenarios. The checks to building the new_services list are now more stringent. https://code.launchpad.net/~makyo/juju-gui/reg-svc-placement/+merge/189665 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Build new_services more carefully #

Patch Set 3 : Build new_services more carefully #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -4 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/views/topology/service.js View 1 chunk +6 lines, -3 lines 0 comments Download
M test/test_environment_view.js View 1 1 chunk +39 lines, -1 line 0 comments Download

Messages

Total messages: 4
matthew.scott
Please take a look.
10 years, 6 months ago (2013-10-07 17:09:37 UTC) #1
gary.poster
Code LGTM, qa good, but as I said on IRC, when I reverted the changes ...
10 years, 6 months ago (2013-10-07 17:26:26 UTC) #2
matthew.scott
Please take a look.
10 years, 6 months ago (2013-10-07 19:51:37 UTC) #3
matthew.scott
10 years, 6 months ago (2013-10-07 20:07:17 UTC) #4
*** Submitted:

Build new_services more carefully

Some services that were not actually new were being considered as such because
their annotations hadn't been processed as attributes yet - this occurred
specifically in drag-and-drop scenarios.  The checks to building the
new_services list are now more stringent.

R=gary.poster
CC=
https://codereview.appspot.com/14499043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b