Issue 14496043: Fix OSX build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14496043: Fix OSX build

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by natefinch

Modified:
10 years, 6 months ago

Reviewers:
gz, mp+189640, fwereade

Visibility:
Public.

Description

Fix OSX build we had no definition of the Home function under juju/osenv for OSX, because all we had was a _linux file and a _windows file. What we really needed was one implementation for Windows and one implementation for everything else. Now that's what we have. For the "everything else" we use the in-file build tag to specify that we don't build this file for Windows. https://code.launchpad.net/~natefinch/juju-core/019-osx-fix/+merge/189640 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	juju/osenv/vars_notwin.go	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fwereade

10 years, 6 months ago (2013-10-07 22:24:27 UTC) #3

I have a report from dstroppa, who's doing the joyent provider, that it's still
not building on OS X for him. Do you have a mac handy to check this against?

Expand All Messages | Collapse All Messages