Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4)

Issue 14494062: code review 14494062: freetype/truetype: propagate the useMyMetrics flag to n... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by nigeltao
Modified:
11 years, 1 month ago
Reviewers:
bsiegert
CC:
bsiegert, golang-dev
Visibility:
Public.

Description

freetype/truetype: propagate the useMyMetrics flag to nested components. Also increase the maximum recursion depth from 4 to 8, since some x-deja-vu-sans-oblique glyphs are actually depth 4. It's an arbitrary limit. The C Freetype code doesn't seem to limit recursion (below whatever the font says it needs), but it seems safer to have a limit.

Patch Set 1 #

Patch Set 2 : diff -r b2e286ac7d3b https://code.google.com/p/freetype-go #

Patch Set 3 : diff -r b2e286ac7d3b https://code.google.com/p/freetype-go #

Patch Set 4 : diff -r b2e286ac7d3b https://code.google.com/p/freetype-go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M freetype/truetype/glyph.go View 1 2 3 4 chunks +6 lines, -4 lines 0 comments Download
M freetype/truetype/truetype_test.go View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 3
nigeltao
Hello bsiegert@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/freetype-go
11 years, 1 month ago (2013-10-16 10:46:23 UTC) #1
bsiegert
LGTM You may want to set the max recursion depth even higher so that J. ...
11 years, 1 month ago (2013-10-16 11:12:19 UTC) #2
nigeltao
11 years, 1 month ago (2013-10-16 23:21:36 UTC) #3
*** Submitted as
https://code.google.com/p/freetype-go/source/detail?r=26847f1046e3 ***

freetype/truetype: propagate the useMyMetrics flag to nested components.

Also increase the maximum recursion depth from 4 to 8, since some
x-deja-vu-sans-oblique glyphs are actually depth 4. It's an arbitrary
limit. The C Freetype code doesn't seem to limit recursion (below
whatever the font says it needs), but it seems safer to have a limit.

R=bsiegert
CC=golang-dev
https://codereview.appspot.com/14494062
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b