Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1346)

Issue 14494055: code review 14494055: go.crypto/ssh: add String method to RejectionReason. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by hanwen-google
Modified:
10 years, 5 months ago
Reviewers:
CC:
agl1, dfc, golang-dev
Visibility:
Public.

Description

go.crypto/ssh: add String method to RejectionReason.

Patch Set 1 #

Patch Set 2 : diff -r bb19605bfacc https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r bb19605bfacc https://code.google.com/p/go.crypto #

Total comments: 2

Patch Set 4 : diff -r bb19605bfacc https://code.google.com/p/go.crypto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M ssh/channel.go View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 5
hanwen-google
Hello agl1, dfc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto
10 years, 5 months ago (2013-10-14 12:43:24 UTC) #1
agl1
https://codereview.appspot.com/14494055/diff/6001/ssh/channel.go File ssh/channel.go (right): https://codereview.appspot.com/14494055/diff/6001/ssh/channel.go#newcode84 ssh/channel.go:84: return "Prohibited" These strings are expected to be put ...
10 years, 5 months ago (2013-10-14 18:16:29 UTC) #2
hanwen-google
https://codereview.appspot.com/14494055/diff/6001/ssh/channel.go File ssh/channel.go (right): https://codereview.appspot.com/14494055/diff/6001/ssh/channel.go#newcode84 ssh/channel.go:84: return "Prohibited" On 2013/10/14 18:16:29, agl1 wrote: > These ...
10 years, 5 months ago (2013-10-14 19:51:55 UTC) #3
agl1
*** Submitted as https://code.google.com/p/go/source/detail?r=04f39b6a609b&repo=crypto *** go.crypto/ssh: add String method to RejectionReason. R=agl, dave CC=golang-dev https://codereview.appspot.com/14494055 ...
10 years, 5 months ago (2013-10-14 20:13:37 UTC) #4
hanwen-google
10 years, 5 months ago (2013-10-14 20:16:51 UTC) #5
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b