Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(498)

Issue 14494048: provider/openstack: disable hostname on request

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by jameinel
Modified:
10 years, 6 months ago
Reviewers:
mp+190052, natefinch
Visibility:
Public.

Description

provider/openstack: disable hostname on request The existing code had logic that would look at the ssl-hostname-verification: false but ignore it if the URL was "http". It turns out that in a live situation it uses http:// for *auth-url* but https:// for other bits like Swift. So just change that bit of logic. If they disabled it, we disable it even if it doesn't matter for the immediate request. https://code.launchpad.net/~jameinel/juju-core/1.16-always-disable-verification-1237219/+merge/190052 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M provider/openstack/provider.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
jameinel
Please take a look.
10 years, 6 months ago (2013-10-09 09:00:34 UTC) #1
natefinch
10 years, 6 months ago (2013-10-09 12:25:55 UTC) #2
On 2013/10/09 09:00:34, jameinel wrote:
> Please take a look.

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b