Issue 144850043: code review 144850043: runtime: fix solaris build, part 2

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 144850043: code review 144850043: runtime: fix solaris build, part 2 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by rsc

Modified:
11 years, 3 months ago

Reviewers:
brainman, iant

CC:
golang-codereviews

Visibility:
Public.

Description

runtime: fix solaris build, part 2 This file was already assigned to another CL so it didn't make it into the build fix CL. Sigh.

Patch Set 2 : diff -r a6bd0b1bb4f5c8f92954a06debeffa4789b64921 https://code.google.com/p/go/ #

Patch Set 3 : diff -r a6bd0b1bb4f5c8f92954a06debeffa4789b64921 https://code.google.com/p/go/ #

Total comments: 2

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -14 lines)			Patch
	M	src/runtime/os_solaris.go	View	1	7 chunks	+15 lines, -14 lines	2 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

rsc

Hello iant (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 3 months ago (2014-09-15 02:24:41 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=a0972e755eff *** runtime: fix solaris build, part 2 This file was already ...

11 years, 3 months ago (2014-09-15 02:24:47 UTC) #2

brainman

LGTM https://codereview.appspot.com/144850043/diff/40001/src/runtime/os_solaris.go File src/runtime/os_solaris.go (right): https://codereview.appspot.com/144850043/diff/40001/src/runtime/os_solaris.go#newcode37 src/runtime/os_solaris.go:37: libcall.args = uintptr(noescape(unsafe.Pointer(&fn))) // it's unused but must ...

11 years, 3 months ago (2014-09-15 02:33:20 UTC) #3

rsc

https://codereview.appspot.com/144850043/diff/40001/src/runtime/os_solaris.go File src/runtime/os_solaris.go (right): https://codereview.appspot.com/144850043/diff/40001/src/runtime/os_solaris.go#newcode37 src/runtime/os_solaris.go:37: libcall.args = uintptr(noescape(unsafe.Pointer(&fn))) // it's unused but must be ...

11 years, 3 months ago (2014-09-15 02:56:10 UTC) #4

brainman

On 2014/09/15 02:56:10, rsc wrote: > > Yes, see TODO line I added above. :-) ...

11 years, 3 months ago (2014-09-15 02:57:47 UTC) #5

Message was sent while issue was closed.

LGTM

Expand All Messages | Collapse All Messages