Issue 14483046: Styling for bundle details charm info

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14483046: Styling for bundle details charm info (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by huwshimi

Modified:
10 years, 7 months ago

Reviewers:
mp+190028, gary.poster

Visibility:
Public.

Description

Styling for bundle details charm info This branch styles the charm details panel that appears on the bundle details tab. To test browse to http://localhost:8888/sidebar/search/bundle/~benji/wiki/5/wiki/:flags:/charmworldv3/?text=wiki and click the visible charm icon. The panel shows a square before the icon has been clicked. This is because the panel showing/hiding has not been implemented yet. This is also why the close icon currently does nothing. https://code.launchpad.net/~huwshimi/juju-gui/bundle-overview-details-styling/+merge/190028 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -8 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	app/assets/images/close-light.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	app/templates/bundle-service-details.handlebars	View	1 chunk	+5 lines, -7 lines	0 comments	Download
A	lib/views/browser/bundle-panel.less	View	1 chunk	+36 lines, -0 lines	0 comments	Download
M	lib/views/browser/tabview.less	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/views/stylesheet.less	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	test/test_bundle_module.js	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gary.poster

Code LGTM. qa OK, given incremental. smells like progress. :-) Thank you! Landing.

10 years, 7 months ago (2013-10-09 13:12:46 UTC) #2

gary.poster

10 years, 7 months ago (2013-10-09 13:18:47 UTC) #3

*** Submitted:

Styling for bundle details charm info

This branch styles the charm details panel that appears on the bundle details
tab.

To test browse to
http://localhost:8888/sidebar/search/bundle/~benji/wiki/5/wiki/:flags:/charmw...
and click the visible charm icon.

The panel shows a square before the icon has been clicked. This is because the
panel showing/hiding has not been implemented yet. This is also why the close
icon currently does nothing.

R=gary.poster
CC=
https://codereview.appspot.com/14483046

Expand All Messages | Collapse All Messages