Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2469)

Issue 14476043: code review 14476043: go.crypto/ssh: move interpretation of msgNewKeys into (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 2 months ago by hanwen-google
Modified:
6 years, 1 month ago
Reviewers:
jpsugar
CC:
kardia, agl1, jpsugar, hanwenn, golang-dev
Visibility:
Public.

Description

go.crypto/ssh: move interpretation of msgNewKeys into transport. Sending the msgNewKeys packet and setting up the key material now happen under a lock, preventing races with concurrent writers.

Patch Set 1 #

Patch Set 2 : diff -r 2cd6b3b93cdb https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r 2cd6b3b93cdb https://code.google.com/p/go.crypto #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -80 lines) Patch
M ssh/client.go View 1 4 chunks +10 lines, -15 lines 0 comments Download
M ssh/common.go View 1 1 chunk +23 lines, -11 lines 0 comments Download
M ssh/kex.go View 1 7 chunks +13 lines, -14 lines 0 comments Download
M ssh/server.go View 1 5 chunks +14 lines, -28 lines 0 comments Download
M ssh/transport.go View 1 10 chunks +78 lines, -12 lines 1 comment Download

Messages

Total messages: 8
hanwen-google
Hello kardianos@gmail.com, agl@golang.org, jpsugar@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto
6 years, 2 months ago (2013-10-06 21:51:14 UTC) #1
hanwenn
This fixes a race condition, and also looks cleaner to me. I hope to decouple ...
6 years, 2 months ago (2013-10-06 22:01:47 UTC) #2
jpsugar
LGTM
6 years, 2 months ago (2013-10-07 17:19:27 UTC) #3
hanwen-google
I've been rereading the RFC for a bit. Once a party has sent a SSH_MSG_KEXINIT ...
6 years, 2 months ago (2013-10-08 10:45:40 UTC) #4
kardia
What problem are you then trying to solve? As I read the RFC, it is ...
6 years, 2 months ago (2013-10-08 15:33:50 UTC) #5
hanwen-google
On Tue, Oct 8, 2013 at 5:33 PM, Daniel Theophanes <kardianos@gmail.com> wrote: > What problem ...
6 years, 2 months ago (2013-10-08 15:42:29 UTC) #6
agl1
*** Submitted as https://code.google.com/p/go/source/detail?r=9ff358df0dad&repo=crypto *** go.crypto/ssh: move interpretation of msgNewKeys into transport. Sending the msgNewKeys ...
6 years, 2 months ago (2013-10-08 19:47:14 UTC) #7
hanwen-google
6 years, 1 month ago (2013-10-13 12:44:38 UTC) #8
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b