Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9)

Issue 14465045: provider/null: wrap bootstrap storage in HTTP

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by axw
Modified:
10 years, 7 months ago
Reviewers:
mp+189523, fwereade
Visibility:
Public.

Description

provider/null: wrap bootstrap storage in HTTP In some cases, the URL of the bootstrap storage is actually used; namely when metadata doesn't exist in the target machine, but tools do. This is problematic for the trunk implementation, as the URLs are using an "sftp" scheme. We fix this by wrapping the bootstrap sshstorage in an httpstorage, listening only on localhost, and using an authkey generated via crypto/rand. Fixes #1235717 https://code.launchpad.net/~axwalk/juju-core/lp1235717-null-provider-bootstrap-storage-http/+merge/189523 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : provider/null: wrap bootstrap storage in HTTP #

Patch Set 3 : provider/null: wrap bootstrap storage in HTTP #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -4 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M provider/null/environ.go View 1 2 3 chunks +55 lines, -2 lines 0 comments Download
M provider/null/environ_test.go View 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 4
axw
Please take a look.
10 years, 7 months ago (2013-10-07 03:20:28 UTC) #1
axw
Please take a look.
10 years, 7 months ago (2013-10-07 07:37:00 UTC) #2
axw
Please take a look.
10 years, 7 months ago (2013-10-07 09:21:39 UTC) #3
fwereade
10 years, 7 months ago (2013-10-08 07:43:12 UTC) #4
As discussed yesterday, probably better to fix up WriteMetadata so it doesn't
require URLs. WIPping in LP.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b