Issue 144650045: code review 144650045: cmd/cgo: add missing ast.SliceExpr.Max case to AST trav...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 144650045: code review 144650045: cmd/cgo: add missing ast.SliceExpr.Max case to AST trav... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by adonovan

Modified:
10 years, 5 months ago

Reviewers:
iant

CC:
rsc, iant, golang-codereviews

Visibility:
Public.

Description

cmd/cgo: add missing ast.SliceExpr.Max case to AST traversal. + static test NB: there's a preexisting (dynamic) failure of test issue7978.go.

Patch Set 1 #

Patch Set 2 : diff -r 6573961dc33e9ed14e548e4db54beda7e862d911 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 6573961dc33e9ed14e548e4db54beda7e862d911 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 6573961dc33e9ed14e548e4db54beda7e862d911 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 07bb65448c694d51ce8bba4b09102c8c04ece2e8 https://code.google.com/p/go/ #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	misc/cgo/test/basic.go	View	1 2 3	1 chunk	+5 lines, -0 lines	0 comments	Download
	M	src/cmd/cgo/ast.go	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

adonovan

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

10 years, 5 months ago (2014-09-30 18:18:37 UTC) #1

adonovan

On 2014/09/30 18:38:36, iant wrote: > Test case? Should be in misc/cgo/test. Done.

10 years, 5 months ago (2014-09-30 19:45:11 UTC) #3

adonovan

10 years, 5 months ago (2014-09-30 20:08:11 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=10574aea99da ***

cmd/cgo: add missing ast.SliceExpr.Max case to AST traversal.

+ static test

NB: there's a preexisting (dynamic) failure of test issue7978.go.

LGTM=iant
R=rsc, iant
CC=golang-codereviews
https://codereview.appspot.com/144650045

Expand All Messages | Collapse All Messages