Issue 14454058: code review 14454058: misc/emacs: handle empty "import ()" in go-goto-imports

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14454058: code review 14454058: misc/emacs: handle empty "import ()" in go-goto-imports (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by Dominik Honnef

Modified:
11 years, 4 months ago

Reviewers:
adonovan

CC:
adonovan, golang-dev

Visibility:
Public.

Description

misc/emacs: handle empty "import ()" in go-goto-imports

Patch Set 1 #

Patch Set 2 : diff -r 52ce02a2718e https://code.google.com/p/go #

Patch Set 3 : diff -r 52ce02a2718e https://code.google.com/p/go #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	misc/emacs/go-mode.el	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Dominik Honnef

Hello adonovan@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 5 months ago (2013-10-10 20:52:25 UTC) #1

adonovan

On 2013/10/18 18:01:10, Dominik Honnef wrote: > PTAL LGTM

11 years, 4 months ago (2013-10-22 16:35:03 UTC) #3

adonovan

11 years, 4 months ago (2013-10-22 16:35:16 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=6b8f33ab7ca4 ***

misc/emacs: handle empty "import ()" in go-goto-imports

R=adonovan
CC=golang-dev
https://codereview.appspot.com/14454058

Committer: Alan Donovan <adonovan@google.com>

Expand All Messages | Collapse All Messages