Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1701)

Issue 14441074: Bootstrap the Juju environment.

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 11 months ago by frankban
Modified:
6 years, 11 months ago
Reviewers:
bac, mp+191410, gary.poster
Visibility:
Public.

Description

Bootstrap the Juju environment. Wait until the API server is ready. Retrieve the API address. Also added --debug support (logging). Tests: `make check`. QA: assuming you have a local provider env named 'local' and an ec2 one named 'ec2' - run `.venv/bin/python juju-quickstart -e local` -> error: the local provider is not currently supported; - run `.venv/bin/python juju-quickstart -e no-such-env` -> error: environment no-such-env not found in ...; - run `juju switch ec2`; - run `.venv/bin/python juju-quickstart --debug` -> the debug messages are shown, the env is bootstrapped, the API URL is printed at the end of the process. - run `.venv/bin/python juju-quickstart` -? like above but this time no debug messages are shown. https://code.launchpad.net/~frankban/juju-gui/quickstart-real-bootstrap/+merge/191410 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Bootstrap the Juju environment. #

Total comments: 4

Patch Set 3 : Bootstrap the Juju environment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+367 lines, -33 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M quickstart/app.py View 1 2 2 chunks +40 lines, -5 lines 0 comments Download
M quickstart/manage.py View 1 6 chunks +28 lines, -2 lines 0 comments Download
M quickstart/tests/helpers.py View 2 chunks +40 lines, -12 lines 0 comments Download
M quickstart/tests/test_app.py View 1 2 2 chunks +154 lines, -0 lines 0 comments Download
M quickstart/tests/test_manage.py View 1 3 chunks +17 lines, -3 lines 0 comments Download
M quickstart/tests/test_utils.py View 2 chunks +47 lines, -7 lines 0 comments Download
M quickstart/utils.py View 5 chunks +39 lines, -4 lines 0 comments Download

Messages

Total messages: 7
frankban
Please take a look.
6 years, 11 months ago (2013-10-16 13:37:39 UTC) #1
bac
LGTM Francesco. I have not yet done QA but can if needed. https://codereview.appspot.com/14441074/diff/1/quickstart/manage.py File quickstart/manage.py ...
6 years, 11 months ago (2013-10-16 14:51:20 UTC) #2
frankban
Please take a look. https://codereview.appspot.com/14441074/diff/1/quickstart/manage.py File quickstart/manage.py (right): https://codereview.appspot.com/14441074/diff/1/quickstart/manage.py#newcode78 quickstart/manage.py:78: if root.handlers: On 2013/10/16 14:51:20, ...
6 years, 11 months ago (2013-10-16 15:23:48 UTC) #3
gary.poster
LGTM with an extremely small suggestion that you are welcome to ignore. It is interesting ...
6 years, 11 months ago (2013-10-16 15:43:40 UTC) #4
bac
QA-OK
6 years, 11 months ago (2013-10-16 15:53:08 UTC) #5
frankban
*** Submitted: Bootstrap the Juju environment. Wait until the API server is ready. Retrieve the ...
6 years, 11 months ago (2013-10-16 16:06:22 UTC) #6
frankban
6 years, 11 months ago (2013-10-16 16:58:46 UTC) #7
Thank you both!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b