Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(507)

Issue 14439054: Fix links in the unit details view.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by frankban
Modified:
10 years, 6 months ago
Reviewers:
mp+190379, jeff.pihach
Visibility:
Public.

Description

Fix links in the unit details view. Handle the juju-core "port/protocol" ports. Privilege the HTTPS port if applicable. Also fixed the z-index of the charm browser tab, so that when the sidebar and the unit details view appear together in a narrow browser it is still possible to close the sidebar. QA: - deploy the GUI with this branch in a juju-core env: juju bootstrap --debug juju deploy juju-gui juju set juju-gui juju-gui-source=lp:~frankban/juju-gui/inspector-who - wait for the unit to be ready; - visit the juju-gui unit detail view; You should be able to close the sidebar view. The GUI address links to the right URL (https://). The ports link to the right URLs without the trailing "/tcp". https://code.launchpad.net/~frankban/juju-gui/inspector-who/+merge/190379 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix links in the unit details view. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+249 lines, -41 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/views/utils.js View 1 chunk +59 lines, -0 lines 0 comments Download
M app/views/viewlets/unit-details.js View 1 chunk +32 lines, -32 lines 0 comments Download
M lib/views/browser/browser-icon.less View 1 chunk +1 line, -1 line 0 comments Download
M test/test_unit_detail_viewlet.js View 3 chunks +40 lines, -8 lines 0 comments Download
M test/test_utils.js View 1 chunk +115 lines, -0 lines 0 comments Download

Messages

Total messages: 5
frankban
Please take a look.
10 years, 6 months ago (2013-10-10 14:30:38 UTC) #1
jeff.pihach
Thanks for this - great tests! QA'd on local provider - all looks good
10 years, 6 months ago (2013-10-10 15:08:33 UTC) #2
jeff.pihach
oops, LGTM
10 years, 6 months ago (2013-10-10 15:09:17 UTC) #3
frankban
*** Submitted: Fix links in the unit details view. Handle the juju-core "port/protocol" ports. Privilege ...
10 years, 6 months ago (2013-10-10 15:15:46 UTC) #4
frankban
10 years, 6 months ago (2013-10-10 15:21:36 UTC) #5
Thanks for the review and QA Jeff!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b