Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1456)

Issue 14438061: Fix upgrade text, remove feature flag

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by matthew.scott
Modified:
10 years, 5 months ago
Reviewers:
rharding, mp+190193, gary.poster
Visibility:
Public.

Description

Fix upgrade text, remove feature flag Upgrade service notification matches designs, feature flag for upgrade charm removed. https://code.launchpad.net/~makyo/juju-gui/upgrade-charm-release/+merge/190193 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix upgrade text, remove feature flag #

Patch Set 3 : Fix upgrade text, remove feature flag #

Patch Set 4 : Fix upgrade text, remove feature flag #

Patch Set 5 : Fix upgrade text, remove feature flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -78 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/app.js View 1 chunk +0 lines, -2 lines 0 comments Download
M app/models/model-controller.js View 1 chunk +1 line, -4 lines 0 comments Download
M app/models/models.js View 2 chunks +3 lines, -4 lines 0 comments Download
M app/templates/inspector-header.handlebars View 1 chunk +3 lines, -2 lines 0 comments Download
M app/views/viewlets/service-overview.js View 1 chunk +39 lines, -42 lines 0 comments Download
M lib/views/juju-inspector.less View 1 chunk +3 lines, -0 lines 0 comments Download
M test/test_endpoints.js View 1 chunk +5 lines, -1 line 0 comments Download
M test/test_inspector_overview.js View 1 13 chunks +13 lines, -21 lines 0 comments Download
M test/test_model_controller.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5
matthew.scott
Please take a look.
10 years, 5 months ago (2013-10-09 17:05:57 UTC) #1
gary.poster
code LGTM. Awesome!!! looking forward to checking it out with qa or after landing.
10 years, 5 months ago (2013-10-09 17:29:31 UTC) #2
rharding
Code looks good, couple of comments. https://codereview.appspot.com/14438061/diff/1/test/test_inspector_overview.js File test/test_inspector_overview.js (left): https://codereview.appspot.com/14438061/diff/1/test/test_inspector_overview.js#oldcode592 test/test_inspector_overview.js:592: window.flags.upgradeCharm = true; ...
10 years, 5 months ago (2013-10-09 18:02:56 UTC) #3
rharding
LGTM qa-ok. I wish we had some sort of notice that it was working when ...
10 years, 5 months ago (2013-10-09 18:30:04 UTC) #4
matthew.scott
10 years, 5 months ago (2013-10-09 22:33:52 UTC) #5
*** Submitted:

Fix upgrade text, remove feature flag

Upgrade service notification matches designs, feature flag for upgrade charm
removed.

R=gary.poster, rharding
CC=
https://codereview.appspot.com/14438061
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b