Copy tools to legacy location on sync

Copy tools to legacy location on sync

When sync-tools runs, it now also copies the tools tarballs
to the legacy <bucket>/tools location as well as the new
simplestreams location. This allows 1.14 code to find the tools
and thus will help with 1.14 ->1.16 upgrades on maas.

https://code.launchpad.net/~wallyworld/juju-core/synctools-to-legacy/+merge/190001

(do not edit description out of merge proposal)

[wallyworld, 2013-10-09 00:56:45]

Please take a look.

[axw, 2013-10-09 04:29:27]

On 2013/10/09 00:56:45, wallyworld wrote:
> Please take a look.

LGTM

[axw, 2013-10-09 04:32:59]

https://codereview.appspot.com/14438058/diff/1/environs/sync/sync_test.go
File environs/sync/sync_test.go (left):

https://codereview.appspot.com/14438058/diff/1/environs/sync/sync_test.go#old...
environs/sync/sync_test.go:186: assertEmpty(c, s.targetEnv.Storage())
Neither here nor there, but "assertEmpty" is a weird name for a function that
checks that there's no tools matching 2.0

[wallyworld, 2013-10-09 05:14:05]

https://codereview.appspot.com/14438058/diff/1/environs/sync/sync_test.go
File environs/sync/sync_test.go (left):

https://codereview.appspot.com/14438058/diff/1/environs/sync/sync_test.go#old...
environs/sync/sync_test.go:186: assertEmpty(c, s.targetEnv.Storage())
On 2013/10/09 04:32:59, axw wrote:
> Neither here nor there, but "assertEmpty" is a weird name for a function that
> checks that there's no tools matching 2.0

Yeah, I should have fixed that when I came across it originally. I'll rename it
now.