To use windows authentication in sharepoint environment with multiple claims providers

To use windows authentication in sharepoint environment with multiple claims providers

When sharepoint is configured with multiple claims providers, authentication mode is "Forms". In browser, when user tries to access site, user is provided with login page to choose "authentication provider".

Customer can configure Adaptor with windows authentication. To force windows authentication, need to include "X-FORMS_BASED_AUTH_ACCEPTED" with value as "f".

Code Commit : https://code.google.com/p/plexi/source/detail?r=05aabcea368ddff6a964f6bcaafa2b48f2a2472a&repo=sharepoint

[Tanmay Vartak, 2013-10-15 21:48:42]

self review :)

https://codereview.appspot.com/14430066/diff/1/src/com/google/enterprise/adap...
File
src/com/google/enterprise/adaptor/sharepoint/FormsAuthenticationHandler.java
(right):

https://codereview.appspot.com/14430066/diff/1/src/com/google/enterprise/adap...
src/com/google/enterprise/adaptor/sharepoint/FormsAuthenticationHandler.java:23:
import java.util.ArrayList;
unused

https://codereview.appspot.com/14430066/diff/1/src/com/google/enterprise/adap...
src/com/google/enterprise/adaptor/sharepoint/FormsAuthenticationHandler.java:25:
import java.util.HashMap;
unused

https://codereview.appspot.com/14430066/diff/1/src/com/google/enterprise/adap...
src/com/google/enterprise/adaptor/sharepoint/FormsAuthenticationHandler.java:53:
= "X-FORMS_BASED_AUTH_ACCEPTED";
unused here. needed in adaptor class

[ejona, 2013-10-16 21:40:44]

https://codereview.appspot.com/14430066/diff/1/src/com/google/enterprise/adap...
File
src/com/google/enterprise/adaptor/sharepoint/FormsAuthenticationHandler.java
(right):

https://codereview.appspot.com/14430066/diff/1/src/com/google/enterprise/adap...
src/com/google/enterprise/adaptor/sharepoint/FormsAuthenticationHandler.java:53:
= "X-FORMS_BASED_AUTH_ACCEPTED";
On 2013/10/15 21:48:43, Tanmay Vartak wrote:
> unused here. needed in adaptor class

It isn't used in the Adaptor class either.

https://codereview.appspot.com/14430066/diff/1/src/com/google/enterprise/adap...
src/com/google/enterprise/adaptor/sharepoint/FormsAuthenticationHandler.java:102:
"Login Cookie Expiration in = {0}", result.getTimeoutSeconds());
The only change on this line is added trailing whitespace :-)

https://codereview.appspot.com/14430066/diff/1/src/com/google/enterprise/adap...
src/com/google/enterprise/adaptor/sharepoint/FormsAuthenticationHandler.java:106:
log.log(Level.INFO,
These two messages should be combined into one. If you only see WARNING
messages, you really want the rest of the description that is in INFO right now.

https://codereview.appspot.com/14430066/diff/1/src/com/google/enterprise/adap...
File src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java (left):

https://codereview.appspot.com/14430066/diff/1/src/com/google/enterprise/adap...
src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java:791: //
JAX-WS RT 2.1.4 doesn't handle headers correctly and always assumes the
Don't remove this comment, although you may choose to modify it.

https://codereview.appspot.com/14430066/diff/1/src/com/google/enterprise/adap...
File src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java
(right):

https://codereview.appspot.com/14430066/diff/1/src/com/google/enterprise/adap...
src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java:804:
disableFormsHeader));
Replace disableFormsHeader with Collections.singletonList("f") ?

https://codereview.appspot.com/14430066/diff/1/src/com/google/enterprise/adap...
src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java:804:
disableFormsHeader));
Indent two more, since it is a continuation of singletonMap()

https://codereview.appspot.com/14430066/diff/1/src/com/google/enterprise/adap...
File
src/com/google/enterprise/adaptor/sharepoint/SharePointUserProfileAdaptor.java
(right):

https://codereview.appspot.com/14430066/diff/1/src/com/google/enterprise/adap...
src/com/google/enterprise/adaptor/sharepoint/SharePointUserProfileAdaptor.java:347:
disableFormsHeader));
Same as in SharePointAdaptor

[ejona, 2013-10-16 22:46:15]

LGTM