Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(196)

Issue 14425057: Add support for xz compression

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by gary.poster
Modified:
10 years, 5 months ago
Reviewers:
bac, mp+190971
Visibility:
Public.

Description

Add support for xz compression An xz tarball reduces the size of the gui code by 30 to 40 percent. These changes let the charm use xz tarballs. A very simple change to the gui makefile will follow. To qa, apply this diff to the gui trunk: === modified file 'Makefile' --- Makefile 2013-10-12 01:30:26 +0000 +++ Makefile 2013-10-14 13:43:10 +0000 @@ -95,7 +95,7 @@ LAUNCHPAD_API_ROOT=staging endif RELEASE_NAME=juju-gui-$(RELEASE_VERSION) -RELEASE_FILE=releases/$(RELEASE_NAME).tgz +RELEASE_FILE=releases/$(RELEASE_NAME).xz RELEASE_SIGNATURE=releases/$(RELEASE_NAME).asc NPM_CACHE_VERSION=$(BZR_REVNO) NPM_CACHE_FILE=$(CURDIR)/releases/npm-cache-$(NPM_CACHE_VERSION).tgz Then run ``BRANCH_IS_GOOD=1 make distfile``. Copy over the new release to the charm's releases directory. If you compare the two file sizes in the charm's releases directory, the difference should be dramatic. $ ls -l -rw-r--r-- 1 gary gary 5076088 Oct 14 09:44 juju-gui-0.10.1+build.1133.xz -rw-r--r-- 1 gary gary 44840221 Oct 12 20:15 juju-gui-0.10.1.tgz You can remove the tgz, and then run juju bootstrap and make deploy in the charm root directory. Once it is deployed, you should be able to log in and see the gui as usual, and you should be able to verify the fact that you are using your custom release if you go to /juju-ui/version.js, where you will see something like "var jujuGuiVersionInfo=['unreleased', '1133'];". Thank you! https://code.launchpad.net/~gary/charms/precise/juju-gui/bug1218888/+merge/190971 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Add support for xz compression #

Patch Set 3 : Add support for xz compression #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -37 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M hooks/utils.py View 3 chunks +7 lines, -3 lines 0 comments Download
M tests/test_utils.py View 4 chunks +75 lines, -34 lines 0 comments Download

Messages

Total messages: 4
gary.poster
Please take a look.
10 years, 5 months ago (2013-10-14 14:26:46 UTC) #1
bac
LGTM and QA ok. Thanks.
10 years, 5 months ago (2013-10-14 17:53:46 UTC) #2
gary.poster
*** Submitted: Add support for xz compression An xz tarball reduces the size of the ...
10 years, 5 months ago (2013-10-14 18:48:47 UTC) #3
gary.poster
10 years, 5 months ago (2013-10-14 18:53:11 UTC) #4
Thank you very much, Brad.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b