code review 14420045: go.crypto/ssh: let client accept DSA and ECDSA host key...

go.crypto/ssh: let client accept DSA and ECDSA host key algorithms.

[hanwen-google, 2013-10-07 13:57:34]

Hello agl, dfc, jpsugar@google.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.crypto

[hanwen-google, 2013-10-07 13:58:39]

question: should we expose the allowed host algorithms in the ClientConfig?

[jpsugar, 2013-10-07 20:25:08]

LGTM

I'm not worried about that at this stage, honestly. It might be nice though,
since by the time the HostKeyChecker is called, we've already negotiated the
host key algo.

[m4dh4tt3r, 2013-10-07 21:20:56]

https://codereview.appspot.com/14420045/diff/3001/ssh/common.go
File ssh/common.go (right):

https://codereview.appspot.com/14420045/diff/3001/ssh/common.go#newcode30
ssh/common.go:30: KeyAlgoECDSA256, KeyAlgoECDSA384, KeyAlgoECDSA521,
Should that be KeyAlgoECDSA512?

[jpsugar, 2013-10-07 21:24:04]

https://codereview.appspot.com/14420045/diff/3001/ssh/common.go
File ssh/common.go (right):

https://codereview.appspot.com/14420045/diff/3001/ssh/common.go#newcode30
ssh/common.go:30: KeyAlgoECDSA256, KeyAlgoECDSA384, KeyAlgoECDSA521,
On 2013/10/07 21:20:56, m4dh4tt3r wrote:
> Should that be KeyAlgoECDSA512?

It's a 521-bit curve. Not a typo. :)

[m4dh4tt3r, 2013-10-07 21:25:55]

On 2013/10/07 21:24:04, jpsugar wrote:
> https://codereview.appspot.com/14420045/diff/3001/ssh/common.go
> File ssh/common.go (right):
> 
> https://codereview.appspot.com/14420045/diff/3001/ssh/common.go#newcode30
> ssh/common.go:30: KeyAlgoECDSA256, KeyAlgoECDSA384, KeyAlgoECDSA521,
> On 2013/10/07 21:20:56, m4dh4tt3r wrote:
> > Should that be KeyAlgoECDSA512?
> 
> It's a 521-bit curve. Not a typo. :)

Gotcha. Sorry for the noise. :-)

[agl1, 2013-10-07 22:29:10]

LGTM.

As for the ClientConfig - seems like a bit of an edge case that the client
doesn't want some host key algorithm.

[agl1, 2013-10-07 22:30:57]

*** Submitted as
https://code.google.com/p/go/source/detail?r=b04aa5dccd15&repo=crypto ***

go.crypto/ssh: let client accept DSA and ECDSA host key algorithms.

R=agl, dave, jpsugar, m4dh4tt3r, agl
CC=golang-dev
https://codereview.appspot.com/14420045

Committer: Adam Langley <agl@golang.org>

[hanwen-google, 2013-10-08 09:05:39]

*** Abandoned ***