Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(430)

Issue 14420045: code review 14420045: go.crypto/ssh: let client accept DSA and ECDSA host key... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by hanwen-google
Modified:
10 years, 5 months ago
Reviewers:
agl1, jpsugar
CC:
agl, dfc, jpsugar, m4dh4tt3r, agl1, golang-dev
Visibility:
Public.

Description

go.crypto/ssh: let client accept DSA and ECDSA host key algorithms.

Patch Set 1 #

Patch Set 2 : diff -r 2cd6b3b93cdb https://code.google.com/p/go.crypto #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -15 lines) Patch
M ssh/common.go View 1 2 chunks +5 lines, -3 lines 2 comments Download
M ssh/test/session_test.go View 1 1 chunk +4 lines, -2 lines 0 comments Download
M ssh/test/test_unix_test.go View 1 3 chunks +22 lines, -10 lines 0 comments Download

Messages

Total messages: 9
hanwen-google
Hello agl, dfc, jpsugar@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto
10 years, 5 months ago (2013-10-07 13:57:34 UTC) #1
hanwen-google
question: should we expose the allowed host algorithms in the ClientConfig?
10 years, 5 months ago (2013-10-07 13:58:39 UTC) #2
jpsugar
LGTM I'm not worried about that at this stage, honestly. It might be nice though, ...
10 years, 5 months ago (2013-10-07 20:25:08 UTC) #3
m4dh4tt3r
https://codereview.appspot.com/14420045/diff/3001/ssh/common.go File ssh/common.go (right): https://codereview.appspot.com/14420045/diff/3001/ssh/common.go#newcode30 ssh/common.go:30: KeyAlgoECDSA256, KeyAlgoECDSA384, KeyAlgoECDSA521, Should that be KeyAlgoECDSA512?
10 years, 5 months ago (2013-10-07 21:20:56 UTC) #4
jpsugar
https://codereview.appspot.com/14420045/diff/3001/ssh/common.go File ssh/common.go (right): https://codereview.appspot.com/14420045/diff/3001/ssh/common.go#newcode30 ssh/common.go:30: KeyAlgoECDSA256, KeyAlgoECDSA384, KeyAlgoECDSA521, On 2013/10/07 21:20:56, m4dh4tt3r wrote: > ...
10 years, 5 months ago (2013-10-07 21:24:04 UTC) #5
m4dh4tt3r
On 2013/10/07 21:24:04, jpsugar wrote: > https://codereview.appspot.com/14420045/diff/3001/ssh/common.go > File ssh/common.go (right): > > https://codereview.appspot.com/14420045/diff/3001/ssh/common.go#newcode30 > ...
10 years, 5 months ago (2013-10-07 21:25:55 UTC) #6
agl1
LGTM. As for the ClientConfig - seems like a bit of an edge case that ...
10 years, 5 months ago (2013-10-07 22:29:10 UTC) #7
agl1
*** Submitted as https://code.google.com/p/go/source/detail?r=b04aa5dccd15&repo=crypto *** go.crypto/ssh: let client accept DSA and ECDSA host key algorithms. ...
10 years, 5 months ago (2013-10-07 22:30:57 UTC) #8
hanwen-google
10 years, 5 months ago (2013-10-08 09:05:39 UTC) #9
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b