Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(60)

Issue 14419062: Deploy bundles from the bundle detail view

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by jeff.pihach
Modified:
10 years, 5 months ago
Reviewers:
mp+190738, gary.poster
Visibility:
Public.

Description

Deploy bundles from the bundle detail view Clicking the 'Deploy' button from the bundle detail view now deploys the bundle. Also added notifications for this button and for drag and drop bundle deployment. https://code.launchpad.net/~hatch/juju-gui/bundle-deploy-button/+merge/190738 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 7

Patch Set 2 : Deploy bundles from the bundle detail view #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -8 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/app.js View 1 2 chunks +18 lines, -0 lines 0 comments Download
M app/subapps/browser/browser.js View 1 chunk +2 lines, -1 line 0 comments Download
M app/subapps/browser/views/bundle.js View 2 chunks +18 lines, -1 line 0 comments Download
M app/subapps/browser/views/charm.js View 1 chunk +1 line, -2 lines 0 comments Download
M app/views/topology/service.js View 1 2 chunks +7 lines, -3 lines 0 comments Download
M app/views/utils.js View 1 1 chunk +18 lines, -0 lines 0 comments Download
M test/test_bundle_details_view.js View 1 2 chunks +17 lines, -1 line 0 comments Download
M test/test_utils.js View 1 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 5
jeff.pihach
Please take a look.
10 years, 5 months ago (2013-10-11 18:02:14 UTC) #1
gary.poster
LGTM and qa ok (given unrelated positiony issues that Makyo is working on) https://codereview.appspot.com/14419062/diff/1/app/app.js File ...
10 years, 5 months ago (2013-10-11 18:21:22 UTC) #2
gary.poster
On 2013/10/11 18:21:22, gary.poster wrote: > LGTM and qa ok (given unrelated positiony issues that ...
10 years, 5 months ago (2013-10-11 18:21:53 UTC) #3
jeff.pihach
Thanks for the review! Landing with changes. https://codereview.appspot.com/14419062/diff/1/app/app.js File app/app.js (right): https://codereview.appspot.com/14419062/diff/1/app/app.js#newcode613 app/app.js:613: As per ...
10 years, 5 months ago (2013-10-11 20:19:43 UTC) #4
jeff.pihach
10 years, 5 months ago (2013-10-11 20:22:19 UTC) #5
*** Submitted:

Deploy bundles from the bundle detail view

Clicking the 'Deploy' button from the bundle detail view
now deploys the bundle. Also added notifications for this
button and for drag and drop bundle deployment.

R=gary.poster
CC=
https://codereview.appspot.com/14419062
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b