Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(905)

Issue 14414044: code review 14414044: freetype: add script to create more hinting tests. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 3 months ago by nigeltao
Modified:
8 years, 3 months ago
Reviewers:
r, bsiegert
CC:
bsiegert, r, golang-dev
Visibility:
Public.

Description

freetype: add script to create more hinting tests.

Patch Set 1 #

Patch Set 2 : diff -r 140544b4efd0 https://code.google.com/p/freetype-go #

Patch Set 3 : diff -r 140544b4efd0 https://code.google.com/p/freetype-go #

Total comments: 18

Patch Set 4 : diff -r 140544b4efd0 https://code.google.com/p/freetype-go #

Patch Set 5 : diff -r 140544b4efd0 https://code.google.com/p/freetype-go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -53 lines) Patch
M cmd/print-glyph-points/main.c View 1 2 3 2 chunks +26 lines, -5 lines 0 comments Download
M freetype/truetype/truetype_test.go View 1 1 chunk +89 lines, -46 lines 0 comments Download
M testdata/README View 1 1 chunk +2 lines, -2 lines 0 comments Download
A testdata/make-other-hinting-txts.sh View 1 2 3 4 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 9
nigeltao
Hello bsiegert@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/freetype-go
8 years, 3 months ago (2013-10-05 01:09:33 UTC) #1
nigeltao
BTW, I'm not very good at bash script, so any advice there is welcome.
8 years, 3 months ago (2013-10-05 01:12:54 UTC) #2
r
comments on sh only https://codereview.appspot.com/14414044/diff/4001/testdata/make-other-hinting-txts.sh File testdata/make-other-hinting-txts.sh (right): https://codereview.appspot.com/14414044/diff/4001/testdata/make-other-hinting-txts.sh#newcode6 testdata/make-other-hinting-txts.sh:6: # It has only been ...
8 years, 3 months ago (2013-10-05 15:50:00 UTC) #3
bsiegert
https://codereview.appspot.com/14414044/diff/4001/cmd/print-glyph-points/main.c File cmd/print-glyph-points/main.c (right): https://codereview.appspot.com/14414044/diff/4001/cmd/print-glyph-points/main.c#newcode10 cmd/print-glyph-points/main.c:10: printf("usage: %s font_size font_file [with_hinting|sans_hinting]\n", argv[0]); no_hinting? https://codereview.appspot.com/14414044/diff/4001/freetype/truetype/truetype_test.go File ...
8 years, 3 months ago (2013-10-05 16:28:07 UTC) #4
nigeltao
https://codereview.appspot.com/14414044/diff/4001/cmd/print-glyph-points/main.c File cmd/print-glyph-points/main.c (right): https://codereview.appspot.com/14414044/diff/4001/cmd/print-glyph-points/main.c#newcode10 cmd/print-glyph-points/main.c:10: printf("usage: %s font_size font_file [with_hinting|sans_hinting]\n", argv[0]); On 2013/10/05 16:28:07, ...
8 years, 3 months ago (2013-10-05 21:56:21 UTC) #5
nigeltao
Ping.
8 years, 3 months ago (2013-10-08 09:02:19 UTC) #6
bsiegert
LGTM modulo the comment below. https://codereview.appspot.com/14414044/diff/4001/testdata/make-other-hinting-txts.sh File testdata/make-other-hinting-txts.sh (right): https://codereview.appspot.com/14414044/diff/4001/testdata/make-other-hinting-txts.sh#newcode8 testdata/make-other-hinting-txts.sh:8: ln -f -s /usr/share/fonts/truetype/droid/DroidSansJapanese.ttf ...
8 years, 3 months ago (2013-10-08 09:04:33 UTC) #7
r
LGTM
8 years, 3 months ago (2013-10-08 13:49:37 UTC) #8
nigeltao
8 years, 3 months ago (2013-10-09 09:07:47 UTC) #9
*** Submitted as
https://code.google.com/p/freetype-go/source/detail?r=00d9ad1a50a7 ***

freetype: add script to create more hinting tests.

R=bsiegert, r
CC=golang-dev
https://codereview.appspot.com/14414044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b