code review 14401043: reflect: test using a MakeFunc value in a couple of dif...

reflect: test using a MakeFunc value in a couple of different ways

The gccgo implementation mishandled calling Interface on a
value created by MakeFunc.

[iant, 2013-10-04 19:45:30]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[r, 2013-10-04 19:51:29]

LGTM
but while you're near there, please tweak the docs for reflect.MakeFunc:

//	- converts its arguments to a list of Values args.

should be

//	- converts its arguments to a slice of Values.

[iant, 2013-10-04 20:12:56]

*** Submitted as https://code.google.com/p/go/source/detail?r=ff2b5ba149ba ***

reflect: test using a MakeFunc value in a couple of different ways

The gccgo implementation mishandled calling Interface on a
value created by MakeFunc.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/14401043

[iant, 2013-10-04 20:13:39]

On Fri, Oct 4, 2013 at 12:51 PM,  <r@golang.org> wrote:
> LGTM
> but while you're near there, please tweak the docs for reflect.MakeFunc:
>
> //      - converts its arguments to a list of Values args.
>
> should be
>
> //      - converts its arguments to a slice of Values.

Done and submitted.

Ian