Issue 14374045: code review 14374045: codereview: move dotfiles out of user home director to ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14374045: code review 14374045: codereview: move dotfiles out of user home director to ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by jas

Modified:
11 years, 6 months ago

Reviewers:
rsc

CC:
golang-dev, r, rsc, aram2

Visibility:
Public.

Description

codereview: move dotfiles out of user home director to something sane. See Rob Pike's lesson on shortcuts, https://plus.google.com/101960720994009339267/posts/R58WgWwN9jp

Patch Set 1 #

Patch Set 2 : diff -r 168efa7a7a36 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 168efa7a7a36 https://code.google.com/p/go/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	lib/codereview/codereview.py	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 9

Expand All Messages | Collapse All Messages

jas

Hello golang-dev@googlegroups.com (cc: aram.h@mgk.ro), I'd like you to review this change to https://code.google.com/p/go/

11 years, 7 months ago (2013-10-04 20:34:28 UTC) #1

Code looks good, but have you signed the CLA (see golang.org/doc/contribute.html)? -rob

11 years, 7 months ago (2013-10-04 20:37:49 UTC) #2

jas

The CLA has just been signed and submitted. -jeff On Oct 4, 2013, at 3:37 ...

11 years, 7 months ago (2013-10-04 21:17:10 UTC) #3

jas

Sent: Date: Fri, 4 Oct 2013 16:16:48 -0500 To: cla-submissions@google.com What's the normal turn around ...

11 years, 7 months ago (2013-10-04 22:41:24 UTC) #5

It should be instantaneous. You just add your name to the spreadsheet, at least as ...

11 years, 7 months ago (2013-10-04 23:26:04 UTC) #6

rsc

11 years, 6 months ago (2013-10-07 15:41:31 UTC) #9

*** Submitted as https://code.google.com/p/go/source/detail?r=97213962a645 ***

codereview: move dotfiles out of user home director to something sane.

See Rob Pike's lesson on shortcuts,
https://plus.google.com/101960720994009339267/posts/R58WgWwN9jp

R=golang-dev, r, rsc
CC=aram.h, golang-dev
https://codereview.appspot.com/14374045

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages