Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(382)

Issue 14368043: code review 14368043: go.tools/godoc: reverse reversed redirects (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 2 months ago by gri
Modified:
9 years, 2 months ago
Reviewers:
adg, rsc, rh
CC:
golang-dev
Visibility:
Public.

Description

go.tools/godoc: reverse reversed redirects Make godoc work again for go spec and memory model doc.

Patch Set 1 #

Patch Set 2 : diff -r 886d6aea7a32 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 886d6aea7a32 https://code.google.com/p/go.tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M godoc/redirect/redirect.go View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5
gri
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools
9 years, 2 months ago (2013-10-03 23:36:32 UTC) #1
gri
*** Submitted as https://code.google.com/p/go/source/detail?r=7750fc1a6bd2&repo=tools *** go.tools/godoc: reverse reversed redirects Make godoc work again for go ...
9 years, 2 months ago (2013-10-03 23:36:36 UTC) #2
adg
Please undo. On 4 October 2013 09:36, <gri@golang.org> wrote: > *** Submitted as > https://code.google.com/p/go/**source/detail?r=7750fc1a6bd2&**repo=tools<https://code.google.com/p/go/source/detail?r=7750fc1a6bd2&repo=tools>*** ...
9 years, 2 months ago (2013-10-03 23:44:28 UTC) #3
rh
Reverse reversing reversed redirects? On Thursday, October 3, 2013 6:43:57 PM UTC-5, Andrew Gerrand wrote: ...
9 years, 2 months ago (2013-10-03 23:45:40 UTC) #4
rsc
9 years, 2 months ago (2013-10-04 01:19:26 UTC) #5
Message was sent while issue was closed.
This fixes godoc used against at tip but will break godoc used against Go 1.1
(golang.org if it gets deployed).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b