Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1205)

Issue 14361044: code review 14361044: freeetype: move the test fonts from the luxi-fonts/ dir... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by nigeltao
Modified:
11 years, 1 month ago
Reviewers:
dsymonds, bsiegert
CC:
dsymonds, bsiegert, golang-dev
Visibility:
Public.

Description

freeetype: move the test fonts from the luxi-fonts/ directory to testdata/, in anticipation of having other test data.

Patch Set 1 #

Patch Set 2 : diff -r d727b2d029b2 https://code.google.com/p/freetype-go #

Patch Set 3 : diff -r d727b2d029b2 https://code.google.com/p/freetype-go #

Patch Set 4 : diff -r d727b2d029b2 https://code.google.com/p/freetype-go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M LICENSE View 1 1 chunk +2 lines, -3 lines 0 comments Download
M cmd/print-glyph-points/main.c View 1 1 chunk +1 line, -1 line 0 comments Download
M example/freetype/main.go View 1 1 chunk +1 line, -1 line 0 comments Download
M example/truetype/main.go View 1 1 chunk +1 line, -1 line 0 comments Download
M freetype/freetype_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M freetype/truetype/truetype_test.go View 1 3 chunks +3 lines, -3 lines 0 comments Download
M testdata/COPYING View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M testdata/README View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M testdata/luximr.ttf View 1 Binary file 0 comments Download
M testdata/luximr.ttx View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M testdata/luxirr.ttf View 1 Binary file 0 comments Download
M testdata/luxirr.ttx View 0 chunks +-1 lines, --1 lines 0 comments Download
M testdata/luxisr.ttf View 1 Binary file 0 comments Download
M testdata/luxisr.ttx View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M testdata/luxisr-12pt-sans-hinting.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M testdata/luxisr-12pt-with-hinting.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 5
nigeltao
Hello bsiegert@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/freetype-go
11 years, 1 month ago (2013-10-03 23:26:28 UTC) #1
nigeltao
dsymonds, do you mind giving this straight-rename CL a review? bsiegert and I are in ...
11 years, 1 month ago (2013-10-04 05:18:13 UTC) #2
bsiegert
LGTM
11 years, 1 month ago (2013-10-04 06:03:30 UTC) #3
dsymonds
LGTM
11 years, 1 month ago (2013-10-04 06:04:50 UTC) #4
nigeltao
11 years, 1 month ago (2013-10-04 07:04:42 UTC) #5
*** Submitted as
https://code.google.com/p/freetype-go/source/detail?r=140544b4efd0 ***

freeetype: move the test fonts from the luxi-fonts/ directory to
testdata/, in anticipation of having other test data.

R=dsymonds
CC=bsiegert, golang-dev
https://codereview.appspot.com/14361044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b