Visit a bundle url displays bundle detail page

Visit a bundle url displays bundle detail page

The only way to display the bundle page right now is to visit a bundle
specific url using the charmworldv3 flag:

http://localhost:8888/bundle/~benji/wiki/wiki/:flags:/charmworldv3/
Will display the small details page using the rough template.

http://localhost:8888/fullscreen/bundle/~benji/wiki/wiki/:flags:/charmworldv3/
Will display the fullscreen details page using the rough template.

https://code.launchpad.net/~hatch/juju-gui/bundle-view-url/+merge/189168

(do not edit description out of merge proposal)

[jeff.pihach, 2013-10-03 19:42:36]

Please take a look.

[jeff.pihach, 2013-10-03 19:45:21]

reviewer notes

https://codereview.appspot.com/14355043/diff/1/app/config-debug.js
File app/config-debug.js (right):

https://codereview.appspot.com/14355043/diff/1/app/config-debug.js#newcode32
app/config-debug.js:32: charmworldURL: 'http://staging.jujucharms.com/',
will be switched back on submitting

https://codereview.appspot.com/14355043/diff/1/app/store/charmworld.js
File app/store/charmworld.js (right):

https://codereview.appspot.com/14355043/diff/1/app/store/charmworld.js#newcod...
app/store/charmworld.js:191: _bundle: function(bundleID, callbacks, bindScope) {
This doesn't yet implement caching like the charms methods do - that'll be in a
followup

https://codereview.appspot.com/14355043/diff/1/app/subapps/browser/browser.js
File app/subapps/browser/browser.js (right):

https://codereview.appspot.com/14355043/diff/1/app/subapps/browser/browser.js...
app/subapps/browser/browser.js:525: var entityId = this._viewState.charmID;
there will need to be continual process to slowly remove all references to
charmID

https://codereview.appspot.com/14355043/diff/1/app/subapps/browser/views/bund...
File app/subapps/browser/views/bundle.js (right):

https://codereview.appspot.com/14355043/diff/1/app/subapps/browser/views/bund...
app/subapps/browser/views/bundle.js:34: events: {
events were copied over - not all callbacks are implemented yet.

[benjamin.saller, 2013-10-03 19:57:02]

This looks like a good start. You seem to know the issues its has, if the plan
is to tackle more in later iterations that is fine. After you respond we can
decide if we should approve or do a bit more.

Thanks

https://codereview.appspot.com/14355043/diff/1/app/store/charmworld.js
File app/store/charmworld.js (right):

https://codereview.appspot.com/14355043/diff/1/app/store/charmworld.js#newcod...
app/store/charmworld.js:191: _bundle: function(bundleID, callbacks, bindScope) {
On 2013/10/03 19:45:21, jeff.pihach wrote:
> This doesn't yet implement caching like the charms methods do - that'll be in
a
> followup

It looks like database doesn't hold the modellist for these, does the store? Its
worth having as these are full remote API requests.

https://codereview.appspot.com/14355043/diff/1/app/subapps/browser/views/bund...
File app/subapps/browser/views/bundle.js (right):

https://codereview.appspot.com/14355043/diff/1/app/subapps/browser/views/bund...
app/subapps/browser/views/bundle.js:34: events: {
On 2013/10/03 19:45:21, jeff.pihach wrote:
> events were copied over - not all callbacks are implemented yet.

I'd remove the ones that are not there yet.

https://codereview.appspot.com/14355043/diff/1/app/subapps/browser/views/bund...
app/subapps/browser/views/bundle.js:69:
this.get('renderTo').setHTML(this.get('container').setHTML(template));
I suppose its here that we'd add the BundleTopo integration, looks simple
enough.

https://codereview.appspot.com/14355043/diff/1/app/templates/bundle.handlebars
File app/templates/bundle.handlebars (right):

https://codereview.appspot.com/14355043/diff/1/app/templates/bundle.handlebar...
app/templates/bundle.handlebars:7: <img src="{{charmIconPath id}}" alt="{{ name
}} icon" class="icon">
we might want to change the helper name in the future, charmworldIconPath for
example.

[benjamin.saller, 2013-10-03 20:02:04]

OK, we talked

LGTM +1

The rest will have to be follow on.

[jeff.pihach, 2013-10-03 20:12:07]

*** Submitted:

Visit a bundle url displays bundle detail page

The only way to display the bundle page right now is to visit a bundle
specific url using the charmworldv3 flag:

http://localhost:8888/bundle/~benji/wiki/wiki/:flags:/charmworldv3/
Will display the small details page using the rough template.

http://localhost:8888/fullscreen/bundle/~benji/wiki/wiki/:flags:/charmworldv3/
Will display the fullscreen details page using the rough template.

R=benjamin.saller
CC=
https://codereview.appspot.com/14355043