Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1945)

Issue 14354043: Use dependencies.tsv when building the tarball.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by curtis
Modified:
10 years, 6 months ago
Reviewers:
axw1, mp+189164, axw
Visibility:
Public.

Description

Use dependencies.tsv when building the tarball. build-release-tarball.bash hard-codes the deps. The script must be hacked to make a release. This branch updated the script to use the deps for the version that is being released. Note that ere is a hack in the rules to accommodate an error in lp:gnuflag. Reoger and I were not able to solve the GhostRevisionsHaveNoRevno, so I use an alterate branch with the same revisions. I hope to resolve the hack in a few days. https://code.launchpad.net/~sinzui/juju-core/build-release-tarball-from-deps/+merge/189164 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Use dependencies.tsv when building the tarball. #

Total comments: 1

Patch Set 3 : Use dependencies.tsv when building the tarball. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -58 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/build-release-tarball/build-release-tarball.bash View 1 2 1 chunk +24 lines, -58 lines 0 comments Download

Messages

Total messages: 7
curtis
Please take a look.
10 years, 7 months ago (2013-10-03 19:32:33 UTC) #1
axw1
On 2013/10/03 19:32:33, curtis wrote: > Please take a look. LGTM, this is great. It ...
10 years, 7 months ago (2013-10-04 01:31:55 UTC) #2
curtis
Please take a look.
10 years, 6 months ago (2013-10-08 20:41:41 UTC) #3
curtis
Per the request to use godeps, I had to do some major restructuring to support ...
10 years, 6 months ago (2013-10-08 20:49:47 UTC) #4
axw
Thanks, LGTM (just one comment typo). Much more maintainable, I think. https://codereview.appspot.com/14354043/diff/5001/scripts/build-release-tarball/build-release-tarball.bash File scripts/build-release-tarball/build-release-tarball.bash (right): ...
10 years, 6 months ago (2013-10-09 01:29:40 UTC) #5
curtis
Please take a look.
10 years, 6 months ago (2013-10-09 18:35:15 UTC) #6
axw
10 years, 6 months ago (2013-10-09 23:54:40 UTC) #7
On 2013/10/09 18:35:15, curtis wrote:
> Please take a look.

Thanks. BTW, if someone says "LGTM with these minor things...", then you can go
ahead and land.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b