Issue 351: Reimplement OAuth2 (Step 4): ServiceAccount and MVC

Issue 351: Reimplement OAuth2 (Step 4): ServiceAccount and MVC

[peleyal, 2013-10-03 13:29:40]

We are very close to commit the huge CL :)
The only things that left:

Windows Phone - Shai from Sela should review it.
This one - Mr. Class :)
And the next one will be Windows 8 (WinRT).

WE ARE VERY CLOSE.
Thanks to all of you!

[class, 2013-10-09 19:27:56]

LGTM, the changes were very minor.

https://codereview.appspot.com/14341043/diff/26001/Src/GoogleApis.Auth/OAuth2...
File Src/GoogleApis.Auth/OAuth2/Web/AuthWebUtility.cs (right):

https://codereview.appspot.com/14341043/diff/26001/Src/GoogleApis.Auth/OAuth2...
Src/GoogleApis.Auth/OAuth2/Web/AuthWebUtility.cs:30: /// In case the data store
is not <c>null</c>, this method verifies that the state parameter which was
returned
"In case the data store is not <c>null</a>"

should probably just be "If the data store is not <c>null</c>" or should be "in
the case where.."

https://codereview.appspot.com/14341043/diff/26001/Src/GoogleApis.Auth/OAuth2...
Src/GoogleApis.Auth/OAuth2/Web/AuthWebUtility.cs:47: // Check that the random
number in the end of the state parameter equals to the one that we stored in
Note that state could be a string. Although the docs call it out as "should be a
random number", this could be any string...

[peleyal, 2013-10-10 19:44:31]

https://codereview.appspot.com/14341043/diff/26001/Src/GoogleApis.Auth/OAuth2...
File Src/GoogleApis.Auth/OAuth2/Web/AuthWebUtility.cs (right):

https://codereview.appspot.com/14341043/diff/26001/Src/GoogleApis.Auth/OAuth2...
Src/GoogleApis.Auth/OAuth2/Web/AuthWebUtility.cs:30: /// In case the data store
is not <c>null</c>, this method verifies that the state parameter which was
returned
On 2013/10/09 19:27:57, class wrote:
> "In case the data store is not <c>null</a>"
> 
> should probably just be "If the data store is not <c>null</c>" or should be
"in
> the case where.."
> 

Done.

https://codereview.appspot.com/14341043/diff/26001/Src/GoogleApis.Auth/OAuth2...
Src/GoogleApis.Auth/OAuth2/Web/AuthWebUtility.cs:47: // Check that the random
number in the end of the state parameter equals to the one that we stored in
On 2013/10/09 19:27:57, class wrote:
> Note that state could be a string. Although the docs call it out as "should be
a
> random number", this could be any string...

Done.