Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(586)

Issue 14341043: Issue 351: Reimplement OAuth2 (Step 4): ServiceAccount and MVC (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 9 months ago by peleyal
Modified:
5 years, 9 months ago
Reviewers:
class
CC:
jonskeet, google-api-dotnet-client_googlegroup.com, shai.raiten_gmail.com
Base URL:
https://google-api-dotnet-client.googlecode.com/hg/
Visibility:
Public.

Description

Issue 351: Reimplement OAuth2 (Step 4): ServiceAccount and MVC

Patch Set 1 #

Patch Set 2 : minor #

Patch Set 3 : rename namespaces #

Patch Set 4 : minor #

Patch Set 5 : minor #

Patch Set 6 : minor #

Total comments: 4

Patch Set 7 : Gus comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+926 lines, -172 lines) Patch
M GoogleApisClient.sln View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
M Src/GoogleApis.Auth.DotNet4/GoogleApis.Auth.DotNet4.csproj View 1 chunk +1 line, -0 lines 0 comments Download
M Src/GoogleApis.Auth.DotNet4/OAuth2/GoogleWebAuthenticationBroker.cs View 1 2 2 chunks +2 lines, -1 line 0 comments Download
A Src/GoogleApis.Auth.DotNet4/OAuth2/ServiceAccountCredential.cs View 1 2 3 4 5 6 1 chunk +338 lines, -0 lines 0 comments Download
M Src/GoogleApis.Auth.DotNet4/Properties/AssemblyInfo.cs View 1 2 1 chunk +1 line, -1 line 0 comments Download
A Src/GoogleApis.Auth.Mvc4/GoogleApis.Auth.Mvc4.csproj View 1 2 3 4 5 1 chunk +144 lines, -0 lines 0 comments Download
A Src/GoogleApis.Auth.Mvc4/OAuth2/Mvc/AuthorizationCodeMvcApp.cs View 1 2 3 4 5 6 1 chunk +67 lines, -0 lines 0 comments Download
A Src/GoogleApis.Auth.Mvc4/OAuth2/Mvc/Controllers/AuthCallbackController.cs View 1 2 3 4 5 1 chunk +103 lines, -0 lines 0 comments Download
A Src/GoogleApis.Auth.Mvc4/OAuth2/Mvc/Filters/AuthActionFilter.cs View 1 2 3 4 5 1 chunk +55 lines, -0 lines 0 comments Download
A Src/GoogleApis.Auth.Mvc4/OAuth2/Mvc/FlowMetadata.cs View 1 2 3 4 5 6 1 chunk +52 lines, -0 lines 0 comments Download
A Src/GoogleApis.Auth.Mvc4/Properties/AssemblyInfo.cs View 1 chunk +40 lines, -0 lines 0 comments Download
A Src/GoogleApis.Auth.Mvc4/packages.config View 1 chunk +12 lines, -0 lines 0 comments Download
M Src/GoogleApis.Auth.Tests/GoogleApis.Auth.Tests.csproj View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Src/GoogleApis.Auth.Tests/OAuth2/Flows/AuthorizationCodeFlowTests.cs View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Src/GoogleApis.Auth/GoogleApis.Auth.csproj View 1 2 1 chunk +6 lines, -5 lines 0 comments Download
M Src/GoogleApis.Auth/OAuth2/AuthorizationCodeInstalledApp.cs View 1 2 2 chunks +2 lines, -1 line 0 comments Download
R Src/GoogleApis.Auth/OAuth2/Credential.cs View 1 2 3 1 chunk +0 lines, -139 lines 0 comments Download
M Src/GoogleApis.Auth/OAuth2/Flows/AuthorizationCodeFlow.cs View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M Src/GoogleApis.Auth/OAuth2/Flows/GoogleAuthorizationCodeFlow.cs View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Src/GoogleApis.Auth/OAuth2/Flows/IAuthorizationCodeFlow.cs View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Src/GoogleApis.Auth/OAuth2/IAuthorizationCodeInstalledApp.cs View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M Src/GoogleApis.Auth/OAuth2/Requests/TokenRequestExtenstions.cs View 1 2 3 2 chunks +2 lines, -3 lines 0 comments Download
M Src/GoogleApis.Auth/OAuth2/UserCredential.cs View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A Src/GoogleApis.Auth/OAuth2/Web/AuthWebUtility.cs View 1 2 3 4 5 6 1 chunk +62 lines, -0 lines 0 comments Download
M Src/GoogleApis.Auth/OAuth2/Web/AuthorizationCodeWebApp.cs View 1 2 3 4 5 6 2 chunks +5 lines, -4 lines 0 comments Download
M Src/GoogleApis.DotNet4/Apis/Util/Store/FileDataStore.cs View 1 2 6 chunks +7 lines, -7 lines 0 comments Download
M Src/GoogleApis/Apis/Services/BaseClientService.cs View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3
peleyal
We are very close to commit the huge CL :) The only things that left: ...
5 years, 9 months ago (2013-10-03 13:29:40 UTC) #1
class
LGTM, the changes were very minor. https://codereview.appspot.com/14341043/diff/26001/Src/GoogleApis.Auth/OAuth2/Web/AuthWebUtility.cs File Src/GoogleApis.Auth/OAuth2/Web/AuthWebUtility.cs (right): https://codereview.appspot.com/14341043/diff/26001/Src/GoogleApis.Auth/OAuth2/Web/AuthWebUtility.cs#newcode30 Src/GoogleApis.Auth/OAuth2/Web/AuthWebUtility.cs:30: /// In case ...
5 years, 9 months ago (2013-10-09 19:27:56 UTC) #2
peleyal
5 years, 9 months ago (2013-10-10 19:44:31 UTC) #3
Message was sent while issue was closed.
https://codereview.appspot.com/14341043/diff/26001/Src/GoogleApis.Auth/OAuth2...
File Src/GoogleApis.Auth/OAuth2/Web/AuthWebUtility.cs (right):

https://codereview.appspot.com/14341043/diff/26001/Src/GoogleApis.Auth/OAuth2...
Src/GoogleApis.Auth/OAuth2/Web/AuthWebUtility.cs:30: /// In case the data store
is not <c>null</c>, this method verifies that the state parameter which was
returned
On 2013/10/09 19:27:57, class wrote:
> "In case the data store is not <c>null</a>"
> 
> should probably just be "If the data store is not <c>null</c>" or should be
"in
> the case where.."
> 

Done.

https://codereview.appspot.com/14341043/diff/26001/Src/GoogleApis.Auth/OAuth2...
Src/GoogleApis.Auth/OAuth2/Web/AuthWebUtility.cs:47: // Check that the random
number in the end of the state parameter equals to the one that we stored in
On 2013/10/09 19:27:57, class wrote:
> Note that state could be a string. Although the docs call it out as "should be
a
> random number", this could be any string...

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b