We are very close to commit the huge CL :) The only things that left: ...
11 years, 1 month ago
(2013-10-03 13:29:40 UTC)
#1
We are very close to commit the huge CL :)
The only things that left:
Windows Phone - Shai from Sela should review it.
This one - Mr. Class :)
And the next one will be Windows 8 (WinRT).
WE ARE VERY CLOSE.
Thanks to all of you!
LGTM, the changes were very minor. https://codereview.appspot.com/14341043/diff/26001/Src/GoogleApis.Auth/OAuth2/Web/AuthWebUtility.cs File Src/GoogleApis.Auth/OAuth2/Web/AuthWebUtility.cs (right): https://codereview.appspot.com/14341043/diff/26001/Src/GoogleApis.Auth/OAuth2/Web/AuthWebUtility.cs#newcode30 Src/GoogleApis.Auth/OAuth2/Web/AuthWebUtility.cs:30: /// In case ...
11 years, 1 month ago
(2013-10-09 19:27:56 UTC)
#2
https://codereview.appspot.com/14341043/diff/26001/Src/GoogleApis.Auth/OAuth2/Web/AuthWebUtility.cs File Src/GoogleApis.Auth/OAuth2/Web/AuthWebUtility.cs (right): https://codereview.appspot.com/14341043/diff/26001/Src/GoogleApis.Auth/OAuth2/Web/AuthWebUtility.cs#newcode30 Src/GoogleApis.Auth/OAuth2/Web/AuthWebUtility.cs:30: /// In case the data store is not <c>null</c>, ...
11 years, 1 month ago
(2013-10-10 19:44:31 UTC)
#3
Message was sent while issue was closed.
https://codereview.appspot.com/14341043/diff/26001/Src/GoogleApis.Auth/OAuth2...
File Src/GoogleApis.Auth/OAuth2/Web/AuthWebUtility.cs (right):
https://codereview.appspot.com/14341043/diff/26001/Src/GoogleApis.Auth/OAuth2...
Src/GoogleApis.Auth/OAuth2/Web/AuthWebUtility.cs:30: /// In case the data store
is not <c>null</c>, this method verifies that the state parameter which was
returned
On 2013/10/09 19:27:57, class wrote:
> "In case the data store is not <c>null</a>"
>
> should probably just be "If the data store is not <c>null</c>" or should be
"in
> the case where.."
>
Done.
https://codereview.appspot.com/14341043/diff/26001/Src/GoogleApis.Auth/OAuth2...
Src/GoogleApis.Auth/OAuth2/Web/AuthWebUtility.cs:47: // Check that the random
number in the end of the state parameter equals to the one that we stored in
On 2013/10/09 19:27:57, class wrote:
> Note that state could be a string. Although the docs call it out as "should be
a
> random number", this could be any string...
Done.
Issue 14341043: Issue 351: Reimplement OAuth2 (Step 4): ServiceAccount and MVC
(Closed)
Created 11 years, 1 month ago by peleyal
Modified 11 years, 1 month ago
Reviewers: class
Base URL: https://google-api-dotnet-client.googlecode.com/hg/
Comments: 4