Issue 14337043: worker/addressupdater: no poll if Addresses unimpl

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14337043: worker/addressupdater: no poll if Addresses unimpl

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by rog

Modified:
10 years, 7 months ago

Reviewers:
dimitern, mp+189048, fwereade

Visibility:
Public.

Description

worker/addressupdater: no poll if Addresses unimpl Fixes https://bugs.launchpad.net/juju-core/+bug/1234534 https://code.launchpad.net/~rogpeppe/juju-core/437-addressupdater-less-polling/+merge/189048 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 3

Patch Set 2 : worker/addressupdater: no poll if Addresses unimpl #

Patch Set 3 : worker/addressupdater: no poll if Addresses unimpl #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -6 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	container/lxc/instance.go	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	errors/errors.go	View	1 2	1 chunk	+21 lines, -0 lines	0 comments	Download
M	errors/errors_test.go	View	1 2	2 chunks	+6 lines, -0 lines	0 comments	Download
M	provider/local/instance.go	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	worker/addressupdater/machine_test.go	View	1 2	4 chunks	+30 lines, -2 lines	0 comments	Download
M	worker/addressupdater/updater.go	View	1 2	2 chunks	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dimitern

Looks good, but I don't get the logic around pollInterval being 1y. https://codereview.appspot.com/14337043/diff/1/errors/errors.go File errors/errors.go ...

10 years, 7 months ago (2013-10-03 11:22:07 UTC) #2

fwereade

Assuming it's too icky to abort the machine loops when we see Unimplemented, LGTM. But ...

10 years, 7 months ago (2013-10-03 13:09:09 UTC) #3

rog

10 years, 7 months ago (2013-10-03 13:31:38 UTC) #5

https://codereview.appspot.com/14337043/diff/1/errors/errors.go
File errors/errors.go (right):

https://codereview.appspot.com/14337043/diff/1/errors/errors.go#newcode89
errors/errors.go:89: type unimplementedError struct {
On 2013/10/03 11:22:07, dimitern wrote:
> I'd prefer to name it notImplementedError, and have a NewNotImplementedError
> respectively.

Done.

Expand All Messages | Collapse All Messages