Issue 14328043: worker/addressupdater: log when addresses change

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14328043: worker/addressupdater: log when addresses change

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by rog

Modified:
10 years, 7 months ago

Reviewers:
dimitern, mp+189012

Visibility:
Public.

Description

worker/addressupdater: log when addresses change This is useful information and worth recording. https://code.launchpad.net/~rogpeppe/juju-core/436-addressupdater-log/+merge/189012 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : worker/addressupdater: log when addresses change #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -0 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	instance/address.go	View	1	2 chunks	+25 lines, -0 lines	0 comments	Download
M	instance/address_test.go	View	1	1 chunk	+45 lines, -0 lines	0 comments	Download
M	worker/addressupdater/machine_test.go	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	worker/addressupdater/updater.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	worker/addressupdater/worker.go	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dimitern

LGTM with a trivial suggestion. https://codereview.appspot.com/14328043/diff/1/worker/addressupdater/updater.go File worker/addressupdater/updater.go (right): https://codereview.appspot.com/14328043/diff/1/worker/addressupdater/updater.go#newcode204 worker/addressupdater/updater.go:204: logger.Infof("machine %q has new ...

10 years, 7 months ago (2013-10-03 09:21:24 UTC) #2

Please take a look.

Expand All Messages | Collapse All Messages