Issue 14324043: Further bundle vis improvements

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14324043: Further bundle vis improvements

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by bcsaller

Modified:
10 years, 6 months ago

Reviewers:
gary.poster, mp+188987

Visibility:
Public.

Description

Further bundle vis improvements Scale to fit Service details in a div on click https://code.launchpad.net/~bcsaller/juju-gui/bundleVis2/+merge/188987 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Further bundle vis improvements #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+155 lines, -30 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	app/templates/bundle-service-details.handlebars	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	app/views/topology/bundle.js	View	6 chunks	+65 lines, -3 lines	0 comments	Download
M	app/views/topology/topology.js	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	app/views/topology/utils.js	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	app/views/viewlet-manager.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/index.html	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	test/test_bundle_module.js	View	5 chunks	+52 lines, -19 lines	0 comments	Download
M	test/utils.js	View	1 chunk	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gary.poster

LGTM. I'd love quick integration instructions to hack in some QA. Thank you!

10 years, 6 months ago (2013-10-03 11:44:28 UTC) #2

bcsaller

10 years, 6 months ago (2013-10-03 16:32:53 UTC) #3

*** Submitted:

Further bundle vis improvements

Scale to fit
Service details in a div on click

R=gary.poster
CC=
https://codereview.appspot.com/14324043

Expand All Messages | Collapse All Messages