code review 143240043: leveldb: consolidated locking with fcntl

leveldb: consolidated locking with fcntl

Since commit 769c936aa54446af2db0c32b3c104e68a4b0cbd5, the Go runtime
has supported direct fcntl locking.  This change proposal drops the
manually-implemented platform locks with the consolidated
sysctl.FcntlFlock interface.

[mtp, 2014-09-22 18:37:43]

Hello nigeltao@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/leveldb-go/

[nigeltao, 2014-09-23 05:03:54]

https://codereview.appspot.com/143240043/diff/50001/leveldb/db/file_lock_fcnt...
File leveldb/db/file_lock_fcntl.go (right):

https://codereview.appspot.com/143240043/diff/50001/leveldb/db/file_lock_fcnt...
leveldb/db/file_lock_fcntl.go:1: // Copyright 2014 The LevelDB-Go Authors. All
rights reserved.
Please rename this file to file_lock_unix.go

https://codereview.appspot.com/143240043/diff/50001/leveldb/db/file_lock_fcnt...
leveldb/db/file_lock_fcntl.go:6: // +build !windows
Delete this line; it's implied by the previous one.

https://codereview.appspot.com/143240043/diff/50001/leveldb/db/file_lock_gene...
File leveldb/db/file_lock_generic.go (right):

https://codereview.appspot.com/143240043/diff/50001/leveldb/db/file_lock_gene...
leveldb/db/file_lock_generic.go:5: // +build !darwin
// +build !darwin,!dragonfly,!freebsd,etc

[mtp, 2014-09-23 09:15:56]

PTAL at your leisure.

https://codereview.appspot.com/143240043/diff/50001/leveldb/db/file_lock_fcnt...
File leveldb/db/file_lock_fcntl.go (right):

https://codereview.appspot.com/143240043/diff/50001/leveldb/db/file_lock_fcnt...
leveldb/db/file_lock_fcntl.go:1: // Copyright 2014 The LevelDB-Go Authors. All
rights reserved.
On 2014/09/23 05:03:54, nigeltao wrote:
> Please rename this file to file_lock_unix.go

Done.

https://codereview.appspot.com/143240043/diff/50001/leveldb/db/file_lock_fcnt...
leveldb/db/file_lock_fcntl.go:6: // +build !windows
On 2014/09/23 05:03:54, nigeltao wrote:
> Delete this line; it's implied by the previous one.

Done.

https://codereview.appspot.com/143240043/diff/50001/leveldb/db/file_lock_gene...
File leveldb/db/file_lock_generic.go (right):

https://codereview.appspot.com/143240043/diff/50001/leveldb/db/file_lock_gene...
leveldb/db/file_lock_generic.go:5: // +build !darwin
On 2014/09/23 05:03:54, nigeltao wrote:
> // +build !darwin,!dragonfly,!freebsd,etc

Done.

[nigeltao, 2014-09-25 00:16:34]

LGTM.

[nigeltao, 2014-09-25 00:17:28]

*** Submitted as
https://code.google.com/p/leveldb-go/source/detail?r=8c09ded0e4ad ***

leveldb: consolidated locking with fcntl

Since commit 769c936aa54446af2db0c32b3c104e68a4b0cbd5, the Go runtime
has supported direct fcntl locking.  This change proposal drops the
manually-implemented platform locks with the consolidated
sysctl.FcntlFlock interface.

LGTM=nigeltao
R=nigeltao
CC=golang-codereviews
https://codereview.appspot.com/143240043

Committer: Nigel Tao <nigeltao@golang.org>