Issue 14315044: provider/null: fix intermittent test failure

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14315044: provider/null: fix intermittent test failure

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by axw

Modified:
10 years, 7 months ago

Reviewers:
mp+188979, thumper

Visibility:
Public.

Description

provider/null: fix intermittent test failure Also, in environs/sshstorage (related to test failure): capture command output in case of outer ssh/bash command failure. Fixes #1234125 https://code.launchpad.net/~axwalk/juju-core/lp1234125-fix-test-race/+merge/188979 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : provider/null: fix intermittent test failure #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -14 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/sshstorage/storage.go	View		4 chunks	+36 lines, -13 lines	0 comments	Download
M	environs/sshstorage/storage_test.go	View		1 chunk	+33 lines, -0 lines	0 comments	Download
M	provider/null/environ_test.go	View	1	1 chunk	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

thumper

10 years, 7 months ago (2013-10-03 03:53:38 UTC) #3

On 2013/10/03 03:49:05, axw wrote:
> Please take a look.

LGTM - with a side of looks weird to me in some places.

Expand All Messages | Collapse All Messages