Issue 14304043: ec2: support instance prefix on group filters

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14304043: ec2: support instance prefix on group filters

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by gz

Modified:
10 years, 6 months ago

Reviewers:
mp+188935, rog

Visibility:
Public.

Description

ec2: support instance prefix on group filters The EC2 API documentation allows for alternative spellings of the group-name and group-id filters on instances. It seems only the prefixed forms are actually supported when using default VPC despite claims to the contrary, so add support for them to the test server infrastructure. https://code.launchpad.net/~gz/goamz/instance_group_filter/+merge/188935 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : ec2: support instance prefix on group filters #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -2 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ec2/ec2t_test.go	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	ec2/ec2test/server.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rog

LGTM assuming the live tests pass. I'm not sure what we should do about testing ...

10 years, 6 months ago (2013-10-02 22:18:52 UTC) #2

On 2013/10/02 22:18:52, rog wrote: > LGTM assuming the live tests pass. $ (cd ec2&&go ...

10 years, 6 months ago (2013-10-02 22:42:53 UTC) #3

10 years, 6 months ago (2013-10-03 12:10:35 UTC) #4

*** Submitted:

ec2: support instance prefix on group filters

The EC2 API documentation allows for alternative spellings of
the group-name and group-id filters on instances. It seems only
the prefixed forms are actually supported when using default VPC
despite claims to the contrary, so add support for them to the
test server infrastructure.

R=rog
CC=
https://codereview.appspot.com/14304043

Expand All Messages | Collapse All Messages