Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(895)

Issue 14302043: ec2: Support groups at instance and reservation

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by gz
Modified:
10 years, 5 months ago
Reviewers:
mp+188906, rog
Visibility:
Public.

Description

ec2: Support groups at instance and reservation Per the 2011-12-15 wsdl description of the EC2 api, the GroupSetType containing security group details appears on both ReservationInfoType and RunningInstancesSetType inside it. This branch updates the code to parse the details at both levels in a RunInstances or DescribeInstances response, and updates the mock server to return the same details at both levels. Change is required as it seems the reservation group set is empty, while the instance group set is not in some circumstances. https://code.launchpad.net/~gz/goamz/secgroups_on_instance/+merge/188906 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : ec2: Support groups at instance and reservation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -22 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M ec2/ec2.go View 1 chunk +17 lines, -16 lines 0 comments Download
M ec2/ec2_test.go View 2 chunks +3 lines, -1 line 0 comments Download
M ec2/ec2test/server.go View 1 chunk +7 lines, -5 lines 0 comments Download
M ec2/responses_test.go View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4
gz
Please take a look.
10 years, 6 months ago (2013-10-02 19:18:08 UTC) #1
rog
On 2013/10/02 19:18:08, gz wrote: > Please take a look. LGTM but perhaps a test ...
10 years, 6 months ago (2013-10-02 19:59:34 UTC) #2
gz
On 2013/10/02 19:59:34, rog wrote: > > LGTM but perhaps a test in ec2i_test.go might ...
10 years, 6 months ago (2013-10-02 21:41:17 UTC) #3
gz
10 years, 5 months ago (2013-10-03 12:09:37 UTC) #4
*** Submitted:

ec2: Support groups at instance and reservation

Per the 2011-12-15 wsdl description of the EC2 api, the
GroupSetType containing security group details appears
on both ReservationInfoType and RunningInstancesSetType
inside it.

This branch updates the code to parse the details at both
levels in a RunInstances or DescribeInstances response,
and updates the mock server to return the same details
at both levels.

Change is required as it seems the reservation group set
is empty, while the instance group set is not in some
circumstances.

R=rog
CC=
https://codereview.appspot.com/14302043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b