Issue 142930043: code review 142930043: go/buildutil: rename AllPackages{,List} -> {ForEachPack...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 142930043: code review 142930043: go/buildutil: rename AllPackages{,List} -> {ForEachPack... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by adonovan

Modified:
10 years, 10 months ago

Reviewers:
gri

CC:
gri, golang-codereviews

Visibility:
Public.

Description

go/buildutil: rename AllPackages{,List} -> {ForEachPackage,AllPackages}. This CL is the first refactoring automated by "gorename". :) Though I had to update the comments and run 'hg gofmt'. :(

Patch Set 1 #

Patch Set 2 : diff -r 86842f45c150d6a706b798c1ece8481b0af2e673 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 86842f45c150d6a706b798c1ece8481b0af2e673 https://code.google.com/p/go.tools #

Patch Set 4 : diff -r 86842f45c150d6a706b798c1ece8481b0af2e673 https://code.google.com/p/go.tools #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -10 lines)			Patch
M	go/buildutil/allpackages.go	View	1 2	4 chunks	+5 lines, -5 lines	0 comments	Download
M	go/buildutil/allpackages_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	go/loader/stdlib_test.go	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	go/pointer/stdlib_test.go	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	go/ssa/stdlib_test.go	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	refactor/importgraph/graph.go	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adonovan

Hello gri@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

10 years, 10 months ago (2014-09-11 18:21:31 UTC) #1

adonovan

10 years, 10 months ago (2014-09-11 18:33:39 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=6a59ff0eac45&repo=tools ***

go/buildutil: rename AllPackages{,List} -> {ForEachPackage,AllPackages}.

This CL is the first refactoring automated by "gorename". :)
Though I had to update the comments and run 'hg gofmt'.   :(

LGTM=gri
R=gri
CC=golang-codereviews
https://codereview.appspot.com/142930043

Expand All Messages | Collapse All Messages