Issue 14290043: code review 14290043: runtime: fix finalizer test on amd64

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14290043: code review 14290043: runtime: fix finalizer test on amd64 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by rsc

Modified:
11 years, 7 months ago

Reviewers:

CC:
golang-dev

Visibility:
Public.

Description

runtime: fix finalizer test on amd64 Not scanning the stack by frames means we are reintroducing a few false positives into the collection. Run the finalizer registration in its own goroutine so that stack is guaranteed to be out of consideration in a later collection. This is working around a regression from yesterday's tip, but it's not a regression from Go 1.1.

Patch Set 1 #

Patch Set 2 : diff -r 414d862c8566 https://code.google.com/p/go/ #

Patch Set 3 : diff -r f280b8a485fd https://code.google.com/p/go/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -8 lines)			Patch
	M	src/pkg/runtime/mfinal_test.go	View	1 2	2 chunks	+11 lines, -8 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev, golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 7 months ago (2013-10-02 16:30:47 UTC) #1

rsc

11 years, 7 months ago (2013-10-02 16:30:52 UTC) #2

*** Submitted as https://code.google.com/p/go/source/detail?r=7266a3768bfa ***

runtime: fix finalizer test on amd64

Not scanning the stack by frames means we are reintroducing
a few false positives into the collection. Run the finalizer registration
in its own goroutine so that stack is guaranteed to be out of
consideration in a later collection.

This is working around a regression from yesterday's tip, but
it's not a regression from Go 1.1.

R=golang-dev
TBR=golang-dev
CC=golang-dev
https://codereview.appspot.com/14290043

Expand All Messages | Collapse All Messages