Issue 14282044: ec2: implemented preparing of configuration

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14282044: ec2: implemented preparing of configuration

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by mue

Modified:
10 years, 7 months ago

Reviewers:
mp+188865, fwereade

Visibility:
Public.

Description

ec2: implemented preparing of configuration Currently the providers don't use Prepare() for the preparing of their configuration. Here this is changed for EC2. So far only the existance and type of "control-bucket" are checked. Other providers will have different checks. https://code.launchpad.net/~themue/juju-core/049-prepare-ec2/+merge/188865 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -1 line)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	provider/ec2/config_test.go	View	1 chunk	+30 lines, -0 lines	1 comment	Download
M	provider/ec2/ec2.go	View	1 chunk	+17 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

fwereade

10 years, 7 months ago (2013-10-02 19:51:33 UTC) #2

If you're on holiday now, I might try to take these over.

https://codereview.appspot.com/14282044/diff/1/provider/ec2/config_test.go
File provider/ec2/config_test.go (right):

https://codereview.appspot.com/14282044/diff/1/provider/ec2/config_test.go#ne...
provider/ec2/config_test.go:348: "control-bucket": 1234,
I don't think we should be accepting bad data and turning it into good -- let's
stick to inserting missing data.

Expand All Messages | Collapse All Messages