Issue 14279043: code review 14279043: flag: remove unused FlagSet.exitOnError field

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14279043: code review 14279043: flag: remove unused FlagSet.exitOnError field (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by chai2010

Modified:
11 years, 5 months ago

Reviewers:
rsc

CC:
golang-dev, rsc

Visibility:
Public.

Description

flag: remove unused FlagSet.exitOnError field

Patch Set 1 #

Patch Set 2 : diff -r 4971493b0e14 http://code.google.com/p/go/ #

Patch Set 3 : diff -r 4971493b0e14 http://code.google.com/p/go/ #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	src/pkg/flag/flag.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

chai2010

Hello golang-dev@googlegroups.com, I'd like you to review this change to http://code.google.com/p/go/

11 years, 9 months ago (2013-10-02 13:44:09 UTC) #1

rsc

not lgtm Sorry, but we're in a freeze leading up to the Go 1.2 release. ...

11 years, 9 months ago (2013-10-02 16:24:57 UTC) #2

rsc

11 years, 7 months ago (2013-12-18 04:18:15 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=8032f18857e5 ***

flag: remove unused FlagSet.exitOnError field

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/14279043

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages