Add flexibility to 'Notify by chat' feature to reduce chat notification volume.

Add flexibility to 'Notify by chat' feature to reduce chat notification volume.

[M-A, 2013-10-10 23:25:16]

https://codereview.appspot.com/14253043/diff/1/codereview/models.py
File codereview/models.py (right):

https://codereview.appspot.com/14253043/diff/1/codereview/models.py#newcode936
codereview/models.py:936: notify_by_chat_exclude_cc_list =
db.BooleanProperty(default=False)
Actually, just make the default make sense. I don't think it needs to be
configurable; if on cc, do not notify.

This will greatly simplify the CL.

https://codereview.appspot.com/14253043/diff/1/codereview/models.py#newcode937
codereview/models.py:937: notify_by_chat_mailed_actions_only =
db.BooleanProperty(default=False)
same

[Ilya Sherman, 2013-10-11 01:14:06]

https://codereview.appspot.com/14253043/diff/1/codereview/models.py
File codereview/models.py (right):

https://codereview.appspot.com/14253043/diff/1/codereview/models.py#newcode936
codereview/models.py:936: notify_by_chat_exclude_cc_list =
db.BooleanProperty(default=False)
On 2013/10/10 23:25:16, M-A wrote:
> Actually, just make the default make sense. I don't think it needs to be
> configurable; if on cc, do not notify.
> 
> This will greatly simplify the CL.

Done.

https://codereview.appspot.com/14253043/diff/1/codereview/models.py#newcode937
codereview/models.py:937: notify_by_chat_mailed_actions_only =
db.BooleanProperty(default=False)
On 2013/10/10 23:25:16, M-A wrote:
> same

Done.

[M-A, 2013-10-11 01:37:31]

lgtm

ping me until death if this CL doesn't get committed in a 'somewhat' timely
manner.

[Ilya Sherman, 2013-10-11 01:40:12]

On 2013/10/11 01:37:31, M-A wrote:
> lgtm
> 
> ping me until death if this CL doesn't get committed in a 'somewhat' timely
> manner.

Thanks!

[M-A, 2013-10-16 19:58:05]

Committed as fdc0541d2fe9.
I changed the CL description because the one you wrote didn't make sense
anymore.