Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(831)

Issue 142470043: code review 142470043: cmd/go: strip -fsanitize= flags when building cgo object (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years ago by dvyukov
Modified:
5 years ago
Reviewers:
gobot, minux, iant
CC:
golang-codereviews
Visibility:
Public.

Description

cmd/go: strip -fsanitize= flags when building cgo object Fixes issue 8788.

Patch Set 1 #

Patch Set 2 : diff -r 39d2fd0bbf77ea59dc92dd2a7e046d37d281e286 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 39d2fd0bbf77ea59dc92dd2a7e046d37d281e286 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 39d2fd0bbf77ea59dc92dd2a7e046d37d281e286 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r 39d2fd0bbf77ea59dc92dd2a7e046d37d281e286 https://dvyukov%40google.com@code.google.com/p/go/ #

Total comments: 1

Patch Set 6 : diff -r 1e2b51e32781fe475a580ffc8a7776507dfec1d5 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 7 : diff -r 128279062c19bc024676f19b0f62f8132ff7da5a https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M src/cmd/go/build.go View 1 2 3 4 5 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 11
dvyukov
Hello iant@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
5 years ago (2014-09-23 04:05:25 UTC) #1
iant
https://codereview.appspot.com/142470043/diff/80001/src/cmd/go/build.go File src/cmd/go/build.go (right): https://codereview.appspot.com/142470043/diff/80001/src/cmd/go/build.go#newcode2340 src/cmd/go/build.go:2340: // Remove any -fsanitize=foo flags. This isn't what I ...
5 years ago (2014-09-23 13:33:40 UTC) #2
dvyukov
Done PTAL
5 years ago (2014-09-24 04:24:24 UTC) #3
iant
LGTM
5 years ago (2014-09-24 13:24:37 UTC) #4
dvyukov
*** Submitted as https://code.google.com/p/go/source/detail?r=d981aaf528df *** cmd/go: strip -fsanitize= flags when building cgo object Fixes issue ...
5 years ago (2014-09-24 21:49:08 UTC) #5
minux
i think this just hide the problem. gcc -Wl,-r will still be broken. the santizer ...
5 years ago (2014-09-25 20:13:36 UTC) #6
dvyukov
You are welcome to join the discussion at: https://code.google.com/p/address-sanitizer/issues/detail?id=344 On Thu, Sep 25, 2014 at ...
5 years ago (2014-09-26 02:15:01 UTC) #7
gobot
This CL appears to have broken the windows-amd64-perf builder. See http://build.golang.org/log/36d41024d8dcef519ef4c9cd6c07391ddbbedac5
5 years ago (2014-09-26 10:27:34 UTC) #8
iant
Wait, I am now puzzled. In a discussion with Russ he pointed out that along ...
5 years ago (2014-09-26 19:58:08 UTC) #9
dvyukov
On Fri, Sep 26, 2014 at 12:58 PM, <iant@golang.org> wrote: > Wait, I am now ...
5 years ago (2014-09-28 04:32:25 UTC) #10
iant
5 years ago (2014-09-28 14:59:01 UTC) #11
On Sat, Sep 27, 2014 at 9:32 PM, Dmitry Vyukov <dvyukov@google.com> wrote:
> On Fri, Sep 26, 2014 at 12:58 PM,  <iant@golang.org> wrote:
>> Wait, I am now puzzled.  In a discussion with Russ he pointed out that
>> along with -Wl,-r, we also pass -nostdlib.
>>
>> Does this mean that the clang driver passes the sanitizer libraries to
>> the linker even if -nostdlib is being used?  Because that is clearly and
>> obviously wrong.  And if the clang driver did not do that, then we would
>> not need this code in the go tool.
>
>
> This was just fixed in clang driver:
> https://code.google.com/p/address-sanitizer/issues/detail?id=344#c14
> But that will be deployed on majority of user machines in like 5
> years, much later than 1.4.

Understood.  But now we see that we are simply working around a bug,
not dealing with some complex interaction.

Ian
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b